This repository was archived by the owner on Mar 29, 2022. It is now read-only.
[:memo:] Extend python docs with lineage tracing#134
Open
phaniarnab wants to merge 2 commits intotugraz-isds:masterfrom
Open
[:memo:] Extend python docs with lineage tracing#134phaniarnab wants to merge 2 commits intotugraz-isds:masterfrom
phaniarnab wants to merge 2 commits intotugraz-isds:masterfrom
Conversation
corepointer
suggested changes
Mar 27, 2020
Collaborator
corepointer
left a comment
corepointer
left a comment
There was a problem hiding this comment.
The docs look good 👍
I spotted a few mistakes though which should be easy to fix.
| Lineage Trace API | ||
| ================= | ||
|
|
||
| Lineage tracing captures every instruction during runtime and store those in a DAG. |
Collaborator
There was a problem hiding this comment.
...and stores them...
| ================= | ||
|
|
||
| Lineage tracing captures every instruction during runtime and store those in a DAG. | ||
| An user can retreive the string representation of a lineage trace by enabling |
Comment on lines
+25
to
+26
| A *lineage item* is composed of an *id*, which is uniquely identifiable | ||
| through an execution, an *opcode* for identifying the physical operation, |
Collaborator
There was a problem hiding this comment.
The id is uniquely identifiable through an execution? Do you mean, that the id uniquely identifies the lineage item throughout a single execution?
Comment on lines
+28
to
+29
| captured instruction, and a *data* attribute, which represents all necessary | ||
| information. It also stores references to other *lineage items* |
Collaborator
There was a problem hiding this comment.
The data attribute represents all necessary information to do what? What do I need the other things like name and id for, when the data attribute represents it all?
|
|
||
| .. note:: | ||
|
|
||
| Lineage trace is captured during execution of an instruction in SystemDS. |
|
|
||
| Lineage trace is captured during execution of an instruction in SystemDS. | ||
| That means, tracing lineage for an intermediate requires SystemDS to lazily | ||
| execute the DAG of operations till the desired node. |
Collaborator
There was a problem hiding this comment.
...until the desired node has been processed.
| That means, tracing lineage for an intermediate requires SystemDS to lazily | ||
| execute the DAG of operations till the desired node. | ||
|
|
||
| The example below traces lineage of an DAG of operations. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.