This repository was archived by the owner on Mar 29, 2022. It is now read-only.
[WIP] Python SystemDSContext instead of shutdown()#131
Open
kev-inn wants to merge 4 commits intotugraz-isds:masterfrom
Open
[WIP] Python SystemDSContext instead of shutdown()#131kev-inn wants to merge 4 commits intotugraz-isds:masterfrom
kev-inn wants to merge 4 commits intotugraz-isds:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switch to using
SystemDSContextas aContextManagerinstead of purely automatic startup and manual shutdown. This makes performance impact more obvious for the user because the expensive startup of a java process happens duringSystemDSContextcreation and allows for us to ensure the closing of the py4j connection and shutdown of subprocess if the user decides to usewith SystemDSContext() as sds:. Manual shutdown with.close()is also possible for cases where the user wants to keep theSystemDSContextaround longer, for example as an member variable of his class.