Unified iteration of TSC and TSCInstance. #282
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominikmaeckel
added
code-quality
There was a problem hiding this comment.
Pull request overview
This pull request unifies the iteration interface for TSC (Timed Scenario Constraint) and TSCInstance by making TSCInstance implement Iterable<TSCInstanceNode>. The changes enable consistent iteration patterns across both TSC and TSCInstance objects, replacing the previous traverse() method with the standard iterator interface.
Key Changes
- Made
TSCInstanceimplementIterable<TSCInstanceNode>with a newTSCInstanceIteratorclass - Updated
generateAllInstances()to returnList<TSCInstance>instead ofList<TSCInstanceNode> - Simplified metric code by replacing
traverse()calls withfilter()on iterable TSCInstance objects
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
TSCNode.kt |
Updated generateAllInstances() return type signature |
TSCBoundedNode.kt |
Updated implementation to wrap nodes in TSCInstance and extract rootNode for edges |
TSCInstanceIterator.kt |
New iterator class for depth-first traversal of TSCInstance nodes |
TSCInstance.kt |
Made class implement Iterable<TSCInstanceNode> with iterator and toString methods |
TSC.kt |
Updated buffer types to store TSCInstance instead of TSCInstanceNode |
MissedPredicatesPerTSCMetric.kt |
Replaced traverse() with filter() on iterable TSCInstance |
MissedPredicateCombinationsPerTSCMetric.kt |
Replaced traverse() with filter() on iterable TSCInstance |
ValidTSCInstancesPerTSCMetric.kt |
Updated equality check to use full TSCInstance comparison |
MissedTSCInstancesPerTSCMetric.kt |
Simplified implementation using list-based tracking instead of map-based flags |
InvalidTSCInstancesPerTSCMetric.kt |
Updated equality check to use full TSCInstance comparison |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...e/src/main/kotlin/tools/aqua/stars/core/metrics/evaluation/MissedTSCInstancesPerTSCMetric.kt
Show resolved
Hide resolved
.../src/main/kotlin/tools/aqua/stars/core/metrics/evaluation/InvalidTSCInstancesPerTSCMetric.kt
Show resolved
Hide resolved
...re/src/main/kotlin/tools/aqua/stars/core/metrics/evaluation/ValidTSCInstancesPerTSCMetric.kt
Show resolved
Hide resolved
stars-core/src/main/kotlin/tools/aqua/stars/core/tsc/instance/TSCInstanceIterator.kt
Outdated
Show resolved
Hide resolved
stars-core/src/main/kotlin/tools/aqua/stars/core/tsc/instance/TSCInstanceIterator.kt
Show resolved
Hide resolved
...e/src/main/kotlin/tools/aqua/stars/core/metrics/evaluation/MissedTSCInstancesPerTSCMetric.kt
Show resolved
Hide resolved
stars-core/src/main/kotlin/tools/aqua/stars/core/tsc/node/TSCNode.kt
Outdated
Show resolved
Hide resolved
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
stars-core/src/main/kotlin/tools/aqua/stars/core/tsc/instance/TSCInstance.kt
Fixed
Show fixed
Hide fixed
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 11 out of 11 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...tlin/tools/aqua/stars/core/metrics/postEvaluation/MissedPredicateCombinationsPerTSCMetric.kt
Outdated
Show resolved
Hide resolved
...tlin/tools/aqua/stars/core/metrics/postEvaluation/MissedPredicateCombinationsPerTSCMetric.kt
Show resolved
Hide resolved
stars-core/src/main/kotlin/tools/aqua/stars/core/tsc/instance/TSCInstance.kt
Outdated
Show resolved
Hide resolved
...src/main/kotlin/tools/aqua/stars/core/metrics/postEvaluation/MissedPredicatesPerTSCMetric.kt
Outdated
Show resolved
Hide resolved
...src/main/kotlin/tools/aqua/stars/core/metrics/postEvaluation/MissedPredicatesPerTSCMetric.kt
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
tillschallau
approved these changes
Dec 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.