Skip to content

Add support for Apple Pay in Popup#112

Open
lukman-paystack wants to merge 1 commit intotubiz:release/5.8.3from
lukman-paystack:feature/apple-pay
Open

Add support for Apple Pay in Popup#112
lukman-paystack wants to merge 1 commit intotubiz:release/5.8.3from
lukman-paystack:feature/apple-pay

Conversation

@lukman-paystack
Copy link
Contributor

Update to use Paystack Checkout API

  • Updated payment flow from newTransaction() to new checkout() method
  • Fixed merchant logo sizing issues (48px height)

@lukman-paystack
Copy link
Contributor Author

Hi @tubiz, could you please help review and merge this PR? Thank you!

@tubiz tubiz changed the base branch from master to release/5.8.3 November 26, 2024 12:21
@tubiz tubiz linked an issue Dec 2, 2024 that may be closed by this pull request
@@ -1,5 +1,6 @@
jQuery( function( $ ) {

$('head').append('<style>.merchant-logo img, img.merchant-logo { max-height: 30px !important; width: auto; }</style>');
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be removed? I guess this is overriding a global style applied by Paystack?

try {
const paystack = new PaystackPop();
paystack.checkout(paymentData).then(function(transaction) {
console.log('Transaction:', transaction);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove logging to the console.

paystack.checkout(paymentData).then(function(transaction) {
console.log('Transaction:', transaction);
}).catch(function(error) {
console.error('Paystack checkout error:', error);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove logging to the console.

console.error('Paystack checkout error:', error);
});
} catch (error) {
console.error('Paystack checkout error:', error);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove logging to the console.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for Apple Pay in Popup

2 participants