Skip to content

Stokes refactor #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
FathimaCSgithub wants to merge 75 commits into
base: 2f-stokes
Choose a base branch
from
Open

Stokes refactor #137

FathimaCSgithub wants to merge 75 commits into from

Conversation

@FathimaCSgithub
Copy link
Contributor

@FathimaCSgithub FathimaCSgithub commented Dec 2, 2025 •
edited
Loading

gas_and_dust_particles Sarracen dataframes for the unit tests were created based on this image.
  • The solid red circles represent gas particles.
  • The blue dots represent dust particles.
  • The pink circles represent the smoothing lengths of the gas particles
  • The blue circles represent the smoothing lengths of the dust particles
  • Gas particle 1 and dust particle 2 are neighbours of each other
  • Gas particle 0 is a neighbour of dust particle 1, but dust particle 1 is not a neighbour of gas particle 0
  • Gas particle 2 is not a neighbour of dust particle 0, but dust particle 0 is a neighbour of gas particle 1
image image

Testing on differing number of dust and gas particles
Same dataset with one more dust particle. Dust particle 4 is a neighbour of gas particle 2 but gas particle 2 is not a neighbour of dust particle 4

image image

Fathima and others added 30 commits August 29, 2025 17:25
bounds based on data instead of name interpolate
8381e2a
@FathimaCSgithub
numpy array
79faf69
@FathimaCSgithub
log
d7b7edf
@FathimaCSgithub
passng in arrays instead of strings
d92ed9b
@FathimaCSgithub
remove log
42c3bb0
@FathimaCSgithub
refacotring default bounds for 2d
b845182
@FathimaCSgithub
temp test
cded1a9
@FathimaCSgithub
revert temp change
ac3d45b
@FathimaCSgithub
default bounding box coordinates func
e9aa050
@FathimaCSgithub
more efficient
98e5565
@FathimaCSgithub
default bounds for render
2099469
@FathimaCSgithub
rotate data func in render
551ce46
@FathimaCSgithub
import pd
6695654
@FathimaCSgithub
added data as param
3c3f49d
@FathimaCSgithub
remove warning
702d133
@FathimaCSgithub
column change bug test
0dedad5
@FathimaCSgithub
possible fix padding
04a7dec
@FathimaCSgithub
remove comments
3b6954c
@FathimaCSgithub
flake8
7d899aa
@FathimaCSgithub
Merge branch 'ttricco:main' into rotationRefactor
b0e8d3f
@FathimaCSgithub
slow attempts
c7c80f1
@FathimaCSgithub
slow attempts
964a0d8
@FathimaCSgithub
attempts
baee22a
@FathimaCSgithub
new attempt
e0fc94e
@FathimaCSgithub
flake8
2ee6ddd
@FathimaCSgithub
figuring out endianness instead of user assigninment
03b1908
@FathimaCSgithub
Merge branch 'ttricco:main' into endian
70701aa
@FathimaCSgithub
big endian change
b2d6bd6
@FathimaCSgithub
fixing cannot byteswap a scalar in-place
793c452
@FathimaCSgithub
array to be byte-swapped is read-only
775d3cb
ttricco and others added 20 commits November 18, 2025 11:28
@ttricco
Merge pull request ttricco#127 from FathimaCSgithub/endian
ceeb1d5 
Allow Endian Swap
@ttricco
remove unused arguments from _default_bounds
d8ae88a
@ttricco
Merge pull request ttricco#126 from FathimaCSgithub/rotationRefactor
78a5016 
Axes limits after rotation
@ttricco
fixes mhd read
f10099d
@ttricco
Merge pull request ttricco#134 from ttricco/read_phantom_mhd_fix
8bbbd8d 
fixes mhd read
@FathimaCSgithub
Merge branch 'ttricco:main' into stokes-refactor
41331f3
stokes in new folder
da04fc2
simplify vstack
09d55d3
adding missing functions
4ce7fa7
moved dim
0f1040c
new func for stokes number specifically
9f84606
minor flake8
dc2b2c6
rename sgrain
5661a78
flake8 and 1 line removal
7e2a66b
renaming and commenting neighbour finding code
c1d7475
@FathimaCSgithub
removing redundancy
8c5ae4b
index
5ebe742
@FathimaCSgithub
index
5803ff1
@FathimaCSgithub
comments
c0557c5
gas neighbour func
7719d98
@ttricco ttricco changed the base branch from main to 2f-stokes December 5, 2025 02:20
@FathimaCSgithub
Copy link
Contributor Author

FathimaCSgithub commented Dec 8, 2025 •
edited
Loading

Made a bare bones unit test based on the image in the PR description

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@FathimaCSgithub @ttricco