Skip to content

Prv leader fix#3

Open
rfabbri wants to merge 2 commits intottm:masterfrom
rfabbri:prv-leader-fix
Open

Prv leader fix#3
rfabbri wants to merge 2 commits intottm:masterfrom
rfabbri:prv-leader-fix

Conversation

@rfabbri
Copy link

@rfabbri rfabbri commented Apr 5, 2018

A proposed fix for the case where the default leaders are being used,
and are not defined in vimrc. I need a review from @ttm regarding the proper handling of prvset.
I noticed that @ttm 's vimrc has all the leaders in prvset explicitly set. But if the user don't set them, they should be sensible defaults. The defaults are set in PRVInit/PRVDefineSettings but I don't know if they are sufficient to get sensible defaults; they seem like a stub:

  if !exists("g:prvset") " for user settings
    let g:prvset = {'leaders' : {}}
  en

At least my basic idea of setting the s: version of the leaders to the defaults is a proposed solution, even though it needs to be polished.

Moreover, I would need @ttm to check my changes in lines 665,666,667 if I am handling correctly the case when prvset.leaders.prv is undefined.

@rfabbri
Copy link
Author

rfabbri commented Apr 5, 2018

Please read the ideas for a better fix here: https://rfabbri.github.io/aa/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant