Open
Conversation
Author
|
Please read the ideas for a better fix here: https://rfabbri.github.io/aa/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A proposed fix for the case where the default leaders are being used,
and are not defined in vimrc. I need a review from @ttm regarding the proper handling of prvset.
I noticed that @ttm 's vimrc has all the leaders in prvset explicitly set. But if the user don't set them, they should be sensible defaults. The defaults are set in PRVInit/PRVDefineSettings but I don't know if they are sufficient to get sensible defaults; they seem like a stub:
At least my basic idea of setting the s: version of the leaders to the defaults is a proposed solution, even though it needs to be polished.
Moreover, I would need @ttm to check my changes in lines 665,666,667 if I am handling correctly the case when prvset.leaders.prv is undefined.