Add an intentional assert fail if the destructor is called.#467
Open
phatpaul wants to merge 1 commit intottlappalainen:masterfrom
Open
Add an intentional assert fail if the destructor is called.#467phatpaul wants to merge 1 commit intottlappalainen:masterfrom
phatpaul wants to merge 1 commit intottlappalainen:masterfrom
Conversation
…A2000 object because it is not implememented and would lead to memory leaks. This should hopefully be a temporary solution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was not clear to me that the class destructor was not implemented and I wasted a lot of my time with memory related issues on my project.
I propose to add an intentional assert failure if the destructor is called on the NMEA2000 object because it is not implemented and would lead to memory leaks.
This should hopefully be a temporary solution until a proper destructor can be implemented. (We tried to implement a proper destructor, but ran into issues with freeing pGroupFunctionHandlers. The AddGroupFunctionHandler() object ownership is ambiguous and it might require a breaking change to the API to fix it). For now I think the best option is to fail-fast instead of causing difficult to diagnose issues.
See discussion in #213
It appears to add about 220 bytes to the binary according to the Memory usage change bot. See the memory report on my fork: phatpaul#2