Draft
Conversation
Part 1/2. Wide characters will be useful in the future, so begin designing the API slowly. Signed-off-by: Aggelos Tselios <aggelostselios777@gmail.com>
Part 2/2. The only thing that remains is testing this on Windows and verifying that it works as expected. Signed-off-by: Aggelos Tselios <aggelostselios777@gmail.com>
Signed-off-by: Aggelos Tselios <aggelostselios777@gmail.com>
Signed-off-by: Aggelos Tselios <aggelostselios777@gmail.com>
tseli0s
added
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wide characters are common on many operating systems. In addition to their expanded character set and support from
libc, they will provide better integration with platforms like Windows and macOS that rely on them extensively. In addition, it will make translation for projects much easier, especially those using less common scripts and languages. GNU/Linux and the BSD family will also be able to make use of them.This PR will add support to NvDialog to work with wide strings. Note that to maintain good ABI compatibility, functions using wide strings will be declared/implemented separately from their regular, C string versions.