Open
Conversation
Fixes example for Linux Mint
Owner
|
You are kind of unlucky because my internet seems to be broken right now in my computer, so I can't really test it myself. Anyways, first of all, you seem to be mentioning a fork somewhere. Are you forking the project or are you contributing code to it? Second, is there a reason that you completely rewrote the example, including the libraries it uses? |
Owner
|
Also, remove the .idea directory or add it to .gitignore at least. |
Author
|
No fork. Just patch. I will likely maintain a copy on my local
workstation to experiment with but anything that comes of value will be
sent back as a PR to you.
Re the example, I used a 'hello world' style starter I use for other
things. I had it as a second example with those libraries but rushed and
nuked yours. It would be better to have both as different binaries showing
different ways of doing it. Please allow me to revise the PR with your
comments including the .idea removal.
…On Thu, Sep 19, 2024 at 9:49 PM Aggelos Tselios ***@***.***> wrote:
You are kind of unlucky because my internet seems to be broken right now
in my computer, so I can't really test it myself.
Anyways, first of all, you seem to be mentioning a fork somewhere. Are you
forking the project or are you contributing code to it?
Second, is there a reason that you completely rewrote the example,
including the libraries it uses?
—
Reply to this email directly, view it on GitHub
<#1 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA2CWVPYUVKJJGEFKABNU73ZXN5KTAVCNFSM6AAAAABOQVU4H6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNRSGU2DONRZGU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
--
Trevor Merritt
GMail user
|
Owner
|
Well take your time because I can't figure for the love of god what's wrong
with my connection - I'll trust you to fix any problems yourself
Στις Παρ, 20 Σεπ 2024, 16:22 ο χρήστης Trevor Merritt <
***@***.***> έγραψε:
… No fork. Just patch. I will likely maintain a copy on my local
workstation to experiment with but anything that comes of value will be
sent back as a PR to you.
Re the example, I used a 'hello world' style starter I use for other
things. I had it as a second example with those libraries but rushed and
nuked yours. It would be better to have both as different binaries showing
different ways of doing it. Please allow me to revise the PR with your
comments including the .idea removal.
On Thu, Sep 19, 2024 at 9:49 PM Aggelos Tselios ***@***.***>
wrote:
> You are kind of unlucky because my internet seems to be broken right now
> in my computer, so I can't really test it myself.
>
> Anyways, first of all, you seem to be mentioning a fork somewhere. Are
you
> forking the project or are you contributing code to it?
>
> Second, is there a reason that you completely rewrote the example,
> including the libraries it uses?
>
> —
> Reply to this email directly, view it on GitHub
> <#1 (comment)>, or
> unsubscribe
> <
https://github.com/notifications/unsubscribe-auth/AA2CWVPYUVKJJGEFKABNU73ZXN5KTAVCNFSM6AAAAABOQVU4H6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNRSGU2DONRZGU>
> .
> You are receiving this because you authored the thread.Message ID:
> ***@***.***>
>
--
Trevor Merritt
GMail user
—
Reply to this email directly, view it on GitHub
<#1 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AVJK5AQFSK422CJWKGGVV3DZXQOTFAVCNFSM6AAAAABOQVU4H6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNRTG4ZDQNRQGA>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes example for Linux Mint, probably breaks it elsewhere. need help to test and fix.
Updates to imgui-rs 0.12.0