feat: implement SPICE error handling and loading state in schematic viewer#150
Open
Devesh36 wants to merge 3 commits intotscircuit:mainfrom
Open
feat: implement SPICE error handling and loading state in schematic viewer#150Devesh36 wants to merge 3 commits intotscircuit:mainfrom
Devesh36 wants to merge 3 commits intotscircuit:mainfrom
Conversation
|
@Devesh36 is attempting to deploy a commit to the tscircuit Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
imrishabh18
requested changes
Dec 12, 2025
Member
imrishabh18
left a comment
imrishabh18
left a comment
There was a problem hiding this comment.
Did you even test your example? I can't see any error it is stuck at this point. Make sure you test your code before requesting reviews
Author
apologies for inconvenience @imrishabh18 sirr |
imrishabh18
requested changes
Dec 12, 2025
Member
imrishabh18
left a comment
imrishabh18
left a comment
There was a problem hiding this comment.
There should be example fixtures for each of the cases of error which you are trying to handle
| error={spiceGenerationError} | ||
| onRetry={onRetry} | ||
| onCopyDetails={() => { | ||
| console.log("Error details copied to clipboard") |
Member
There was a problem hiding this comment.
Suggested change
| console.log("Error details copied to clipboard") |
| onRetry={onRetry} | ||
| onCopyDetails={() => { | ||
| // Optional: show toast notification when copied | ||
| console.log("Error details copied to clipboard") |
Member
There was a problem hiding this comment.
Suggested change
| console.log("Error details copied to clipboard") |
| ) | ||
| setIsLoading(false) | ||
| } | ||
| }, 10000) |
Member
There was a problem hiding this comment.
Make the timeout configurable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant improvements to the SPICE simulation error handling and user experience in the schematic viewer. It adds a user-friendly error display component, a new loading state indicator, and enhances the retry logic for failed simulations. These changes make simulation errors much clearer and more actionable for users, and improve the overall UI responsiveness during simulation runs.
SPICE Simulation Error Handling and UI Improvements:
SpiceErrorDisplaycomponent that categorizes SPICE errors, provides user-friendly messages, suggestions, technical details, and actions such as retry and copy error details. This replaces the previous generic error display. [1] [2]SpiceErrorDisplayandLoadingStatecomponents into the simulation workflow, replacing plain text loading/error messages with more informative and visually appealing UI elements inSpicePlotandSpiceSimulationOverlay. [1] [2] [3]Retry Logic and Simulation State Management:
spiceRetryCounterstate and passing it to theuseSpiceSimulationhook, ensuring that retries trigger a new simulation run. [1] [2] [3] [4] [5]onRetryprop support to relevant components (SpicePlot,SpiceSimulationOverlay,SchematicViewer) to allow users to retry failed simulations directly from the UI. [1] [2] [3] [4] [5]New Components and Exports:
LoadingStateandSpiceErrorDisplaycomponents for use in other parts of the application or by consumers of the library. [1] [2]Miscellaneous UI and Code Quality Improvements:
type="button"to button elements and minor style/code cleanups. [1] [2] [3]These changes collectively provide a much better user experience when running and debugging SPICE simulations.
/fix #113