Fix schematic trace hover highlighting (#1130)#147
Open
FizaSiddique123 wants to merge 2 commits intotscircuit:mainfrom
Open
Fix schematic trace hover highlighting (#1130)#147FizaSiddique123 wants to merge 2 commits intotscircuit:mainfrom
FizaSiddique123 wants to merge 2 commits intotscircuit:mainfrom
Conversation
|
@FizaSiddique123 is attempting to deploy a commit to the tscircuit Team on Vercel. A member of the Team first needs to authorize it. |
Author
|
I’ve verified the fix with bun start in schematic-viewer and tested the Cosmos fixture (example7). Hovering traces now highlights the correct net consistently. Please let me know if you’d like any changes |
Author
|
Hi! I have created PR #147 for this issue. |
techmannih
requested changes
Dec 7, 2025
Member
techmannih
left a comment
There was a problem hiding this comment.
Please add before and after screenshot/video
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Fixes #1130
Problem
Schematic traces did not expose a stable identifier to connect them to a net, so hover highlighting could not reliably determine which trace/net to highlight.
Changes
data-net-idto each trace path based on:data-schematic-trace-id/data-schematic-object-idtraceIdToNetIdmap when net information is availablemouseenter/mouseleavehandlers on[data-net-id]elements to track the currently hovered net.trace-hoverCSS class to all traces that share the samedata-net-idTesting
bun startinschematic-viewer/data-net-idhighlight together