Add double click handler for schematic components#133
Add double click handler for schematic components#133nailoo wants to merge 20 commits intotscircuit:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
lib/components/SchematicViewer.tsx
Outdated
| clickToInteractEnabled, | ||
| isInteractionEnabled, | ||
| showSpiceOverlay, | ||
| ]) |
There was a problem hiding this comment.
too much code in this file (keep things clean, move functionality to separate files appropriately)
seveibar
left a comment
seveibar
left a comment
There was a problem hiding this comment.
looks good, see comment
I think we also need a background color or border sort of highlight on each component to make it clear they're clickable
CC @ShiboSoftwareDev this is relevant for configuring voltage sources for simulation, the user will click to configure
|
I guess he meant highlight/border on hover not all the time |
|
@ShiboSoftwareDev I have update now only highlight on hover 21.09.2025_01.41.54_REC.mp4 |
seveibar
left a comment
seveibar
left a comment
There was a problem hiding this comment.
the soft glow is cool but for engineering tools stylistically they tend to prefer sharp blue or red lines for highlights
|
Reviewed, couple issues:
|
|
It's completed in #136 |
4 participants
update video
21.09.2025_01.41.54_REC.mp4
20.09.2025_22.53.49_REC.mp4
Fix #132
/claim #132