Conversation
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
| import { expect, test } from "bun:test" | ||
| import { compareFootprinterVsKicad } from "../fixtures/compareFootprinterVsKicad" | ||
| import { convertCircuitJsonToPcbSvg } from "circuit-to-svg" | ||
|
|
||
| test("parity/plcc44", async () => { | ||
| const { combinedFootprintElements, booleanDifferenceSvg } = | ||
| await compareFootprinterVsKicad( | ||
| "plcc44_w16.6_h16.6_p1.27mm", | ||
| "Package_LCC.pretty/PLCC-44_16.6x16.6mm_P1.27mm.circuit.json", | ||
| ) | ||
|
|
||
| const svgContent = convertCircuitJsonToPcbSvg(combinedFootprintElements) | ||
| expect(svgContent).toMatchSvgSnapshot(import.meta.path, "plcc44_parity") | ||
| expect(booleanDifferenceSvg).toMatchSvgSnapshot( | ||
| import.meta.path, | ||
| "plcc44_parity._boolean_difference", | ||
| ) | ||
| }) |
There was a problem hiding this comment.
The test file name 'plcc_kikac_parity.test.ts' contains a typo ('kikac' instead of 'kicad') and doesn't follow proper kebab-case naming convention. The file name should be consistent with the project naming standards and should be 'plcc-kicad-parity.test.ts' to match kebab-case convention and correct the spelling error.
Spotted by Graphite Agent (based on custom rule: Custom rule)
Is this helpful? React 👍 or 👎 to let us know.
techmannih
left a comment
techmannih
left a comment
There was a problem hiding this comment.
Ref text is overlapping with the pads
| pl: length.optional(), | ||
| thermalpad: z.union([z.literal(true), dim2d]).optional(), | ||
| legsoutside: z.boolean().default(false), | ||
| pcdfe: length.optional(), |
There was a problem hiding this comment.
its Pad Center Distance From Edge, actaully my parity test was failing as you know in pr.
I have introduced this to dyanmically able to change position of pads from center.
Earlier there was only one option of legsoutside?: boolean but this was enough to perfectly place pads to kikad footprint.
I have take care for other taste to not break.
There was a problem hiding this comment.
Should i Add comments for this ?
There was a problem hiding this comment.
@Sahil-Gupta584 if you are using this flags then please describe it with . describe()
Do i need to place it to middle of top side? |
|
Yes , it should be to big and bot too small, take help from others footprint how's there |
2 participants
part #2