Open
Conversation
techmannih
requested changes
Jan 7, 2026
Member
techmannih
left a comment
techmannih
left a comment
There was a problem hiding this comment.
Please add kicad parity test
Sahil-Gupta584
force-pushed
the
add-soj-fp
branch
from
cf731ec to
eb13ebb
Compare
Author
techmannih
reviewed
Jan 12, 2026
Member
techmannih
left a comment
techmannih
left a comment
There was a problem hiding this comment.
Ref text should be small, not too big like this. You can see another footprint as a reference
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
techmannih
reviewed
Jan 14, 2026
techmannih
reviewed
Jan 14, 2026
Member
techmannih
left a comment
techmannih
left a comment
There was a problem hiding this comment.
Are you really need this flag? can you describe it.
Author
updated the pr desscription |
rushabhcodes
requested changes
Jan 15, 2026
Contributor
There was a problem hiding this comment.
Is the change in the file soic.ts unrelated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
part of #2
Introduces a new flag
reftextsizeforextendSoicDef.Sometimes not all footprints have the same no. of pads, some footprints are smaller and some are larger.
The ref textsize gets changed automatically according to footprint.
In this , soj fp case, the automatic or say earlier implmentation of ref text size wasnt good enough(was v small) to maintain the ref text size so i needed a flag to adjust the text-size without breaking other footpints tests.