feat: enhance SOP-8 footprint definition and add tests for KiCad parity#430
Open
rushabhcodes wants to merge 3 commits intotscircuit:mainfrom
Open
feat: enhance SOP-8 footprint definition and add tests for KiCad parity#430rushabhcodes wants to merge 3 commits intotscircuit:mainfrom
rushabhcodes wants to merge 3 commits intotscircuit:mainfrom
Conversation
techmannih
requested changes
Nov 22, 2025
Member
techmannih
left a comment
techmannih
left a comment
There was a problem hiding this comment.
KiCad test is correct, but you still need to verify and use standard pad dimensions (length & width). Also, the ref text is not positioned correctly — when the CAD model is placed on top of the pads, the reference text should not be visible
Contributor
Author
Member
|
Silkscreen line should be a little bit upper |
Contributor
Author
Is this correct
|
Member
|
Yea also increase the distance between ref text and silkscreen line |
Contributor
Author
Contributor
Author
|
Please review @techmannih |
techmannih
approved these changes
Nov 23, 2025
Member
|
sorry for delay |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the SOP-8 footprint definition and improves type safety in the
sop8generator, while also adding a new test for KiCad parity. The main changes include specifying physical parameters for the SOP-8 package, updating type annotations for better clarity, and introducing a snapshot test to ensure the generated footprint matches KiCad's output.SOP-8 footprint improvements:
w,p,pw,pl) to thesop8_defdefinition to match SOP-8 package specifications.sop8function and related arrays fromAnySoupElementtoAnyCircuitElementfor improved type safety and clarity. [1] [2]Testing enhancements:
sop8_kicad_parity.test.ts) to compare the generated SOP-8 footprint against KiCad's version, including SVG output and boolean difference checks.Before and After
KiCad Parity