fix: add footprint test for spdip-28#426
Conversation
nailoo
left a comment
There was a problem hiding this comment.
dip and spdip are same???
They are as far as I have been able to tell. See the "expand" part of my description comment above for the Google AI overview of what SPDIP-28 means. |
techmannih
left a comment
There was a problem hiding this comment.
@joncherry i think you need to implement spdip footprint cc @seveibar

@techmannih that AI answer is still saying basically the same thing as the AI answer in my "expand" section. The S in SPDIP stands for skinny. The only difference is the width and perhaps pitch as far as I can find online. |
|
@techmannih see https://ww1.microchip.com/downloads/aemDocuments/documents/corporate-responsibilty/environmental/material-compliance-documents/28L_SPDIP_300_SP_C04-070B.pdf from my description comment above which is the pdf that I used as my source for dimensions. Edit: looks like kicad viewer has smdip but doesn't have spdip. |
|
@joncherry I reviewed your PDF — it documents the CAD model, but it doesn’t cover the footprints. It looks like you converted a dip into an spdip, but dip and spdip are distinct footprints and shouldn’t be treated as the same. Please either update the PDF to include the correct footprint details and implement a proper spdip footprint. |
@techmannih the PDF is just one that I found online and not mine. I don't know what differences there are between spdip and dip except for primarily width. If there is no other difference, but you just want a separate file for spdip, that is one thing -- But if there is another difference in the footprints, then I would need you to tell me about it, because I have not found any online after looking through a lot of docs. I can also just close this PR if this is just something needs to be handled by someone with greater understanding of spdip. |
rushabhcodes
left a comment
There was a problem hiding this comment.
can you add kicad parity test too if possible
@rushabhcodes For SPDIP, there is no footprint in kicad viewer or kicad libraries https://gitlab.com/kicad/libraries/kicad-footprints. However I did find SPDIP on these kicad repos for symbols. and https://gitlab.com/kicad/libraries/kicad-symbols/-/blob/master/MCU_Microchip_PIC18.kicad_sym#L2957 https://gitlab.com/kicad/libraries/kicad-symbols/-/blob/master/MCU_Microchip_PIC18.kicad_sym#L2976 Which seems to further support that the footprint for SPDIP is a dip footprint. |
|
@techmannih I have moved on to other projects, so I won't be working on this anymore. Anyone can feel free to take over or borrow from this PR. I hope the work I have done is useful to someone. |
/closes #180
Summary
It appears to me that the issue for SPDIP-28 fits into the dip function at
src/fn/dip.tsso I have added a test for that.Evidence
I looked at this doc. When converting from inches to mm in the doc, the my new test seems to have good dimensions that match the doc. 0.300 inch width and 0.100 inch pitch become 7.62mm and 2.54mm respectively. The pin diameter of 0.018 inch becomes 0.457 mm which should fit into the default ID of the pin holes on the test which seems to be 1.0mm
https://ww1.microchip.com/downloads/aemDocuments/documents/corporate-responsibilty/environmental/material-compliance-documents/28L_SPDIP_300_SP_C04-070B.pdf
also the footprint visually resembles the footprint from jlc search:

https://jlcsearch.tscircuit.com/components/list?package=SPDIP-28
Here's the Google AI overview of what SPDIP-28 means:
expand
In a PCB context, SPDIP-28 refers to a specific type of integrated circuit (IC) package, describing its physical characteristics and pin count. Meaning of each partKey characteristics for PCB design