Open
Conversation
There was a problem hiding this comment.
Bug: Direct Mutation Causes Unintended Side Effects
The lqfn function directly mutates its input parameters object by setting parameters.legsoutside = false. This modifies the caller's object, which can cause unexpected side effects if the original object is reused. The function should instead create a copy of the parameters, for example, using object spreading: return quad({ ...parameters, legsoutside: false }).
src/fn/lqfn.ts#L9-L10
Lines 9 to 10 in bd180fa
BugBot free trial expires on July 22, 2025
You have used $0.00 of your $50.00 spend limit so far. Manage your spend limit in the Cursor dashboard.
Was this report helpful? Give feedback by reacting with 👍 or 👎
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
BUN_UPDATE_SNAPSHOTS=1 bun test tests/lqfn.test.tshttps://chatgpt.com/codex/tasks/task_b_686b1007c33c832e9946acce16b9b1a2