fix: remove the redundant 2 point traces which end at via when 3+ point trace is present ending at same via #115
Conversation
…nt trace is present ending at same via
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| return ( | ||
| viaLocations.has(otherLastKey) && | ||
| (otherLastKey === firstKey || otherLastKey === lastKey) | ||
| ) | ||
| }) |
There was a problem hiding this comment.
The new pruning logic considers a two‑point trace to a via redundant as soon as any 3+ point trace on the same layer ends at that via (lines 181‑185), and that flag is used immediately after to delete the short trace. Because the other endpoint of the longer trace is not checked, a net with multiple branches into the same via (e.g. a simple via→pad stub plus a longer via→other pad route) will have the shorter branch removed even though it is the only connection to its pad, breaking connectivity. The condition should also verify the non‑via endpoint matches before dropping the shorter segment.
Useful? React with 👍 / 👎.
No stub anymore