add texture support for Box component#649
Open
anzal787 wants to merge 2 commits intotscircuit:mainfrom
Open
Conversation
This PR implements texture support for the Box component as requested in issue tscircuit#534.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
| (boardOutlineBounds.maxY - pcbY) * traceTextureResolution | ||
| export const Box = ({ width, height, depth, textureUrl }: Props) => { | ||
| // UseLoader wuxuu soo rarayaa sawirka PNG-ga ah ee textureUrl laga keenay | ||
| const texture = textureUrl ? useLoader(THREE.TextureLoader, textureUrl) : null |
Contributor
There was a problem hiding this comment.
React hook useLoader is being called conditionally, which violates the Rules of Hooks and will cause runtime errors. Hooks must be called at the top level of the component unconditionally.
Fix:
const texture = useLoader(THREE.TextureLoader, textureUrl || '')Then conditionally use the texture only if textureUrl is provided:
const actualTexture = textureUrl ? texture : nullOr use a separate component for the texture loading case.
Suggested change
| const texture = textureUrl ? useLoader(THREE.TextureLoader, textureUrl) : null | |
| const texture = useLoader(THREE.TextureLoader, textureUrl || '') | |
| const actualTexture = textureUrl ? texture : null | |
Spotted by Graphite Agent
Is this helpful? React 👍 or 👎 to let us know.
rushabhcodes
requested changes
Jan 13, 2026
Contributor
rushabhcodes
left a comment
rushabhcodes
left a comment
There was a problem hiding this comment.
Type check is failing,
Format check is failing,
Also you removed already existing texture
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #534