update to setuptools and enable msvc compilation by default#6
Open
MSSandroid wants to merge 6 commits intotsaoyu:masterfrom
Open
update to setuptools and enable msvc compilation by default#6MSSandroid wants to merge 6 commits intotsaoyu:masterfrom
MSSandroid wants to merge 6 commits intotsaoyu:masterfrom
Conversation
Owner
|
Looks ok, but a sad story is that I lost my access to PyPI for the package release. |
Owner
|
Thank you for your commit and I will reach to you once I recover it. It may takes some times |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I changed distutils to setuptools (distutils is deprecated) and enabled the installation under windows (by uncommenting some of the msvc comments).
In my test this version also installs without issues under linux, so i propose to leave the lines uncommented by default.
Also added some instructions for the installation on windows.