Feature: Add complex notifications #166
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Photino's ability to create notifications is extremely basic and only allows setting the title and message. This PR aims to add support for more complex Windows notifications.
Breaking changes:
Photino::ShowNotificationhas been removedImplementation:
PhotinoWindowhas a new method calledCreateNotificationthat is used to build a notification. The notification can then be shown by callingShow(). Action buttons can also be added to the notification with a callback.Example:
On the C++ side, in keeping with the intention of Photino being cross platform a layer of abstraction on top of WinToastLib has been created. Photino now has its own PhotinoNotification type. This should allow notifications for Linux and macOS to be added later on. I tried to keep the implementation as platform agnostic as possible, so some changes may need to be made to the enum namings, but names are currently heavily borrowed from Windows/WinToastLib.