Allow parent window to be set before initialized #264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to set the parent window on a new window before it's instantiated. This allows applications built with photino.Blazor to have new windows with parents.
photino.Blazor utilizes dependency injection when creating new windows, so each window is effectively a separate Blazor app. This creates the undesired UI effect where one application can look like multiple. i.e. on Windows, multi-window Photino Blazor applications will not combine under one taskbar item.
A check was put in place to make sure that a native instance of the current window does not already exist. As the parent is used as a startup parameter, this mirrors checks put in for other pre-instantiated parameters such as chromeless.