-
Notifications
You must be signed in to change notification settings - Fork 3
fix: add filter display setting and revert name changes (#548) #552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- Add a "Filter Display" setting in Settings > Models to toggle between showing provider names (default) or icons in model selector filter tabs - Revert "Meta Llama" → "Llama" renaming from PR #551 (keep original names) - Persist filter display preference in localStorage via the UI store Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
🚅 Deployed to the openchat-pr-552 environment in OpenChat
|
Greptile SummaryThis PR introduces a user-configurable filter display setting that allows toggling between provider names (default) and icons in the model selector filter tabs. The implementation reverts the "Meta Llama" → "Llama" name change from PR #551, restoring the original provider naming convention. Key Changes:
Technical Implementation: Minor Style Issue: Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant User
participant Settings
participant UIStore
participant LocalStorage
participant ModelSelector
participant FilterTabs
Note over User,FilterTabs: Initial Load
UIStore->>LocalStorage: Load persisted filterStyle
LocalStorage-->>UIStore: Return "names" (default)
ModelSelector->>UIStore: Read filterStyle
UIStore-->>ModelSelector: "names"
ModelSelector->>FilterTabs: Render provider names (no icons)
Note over User,FilterTabs: User Changes Preference
User->>Settings: Click "Icons" button
Settings->>UIStore: setFilterStyle("icons")
UIStore->>LocalStorage: Persist filterStyle="icons"
Note over User,FilterTabs: UI Updates
ModelSelector->>UIStore: Read filterStyle (reactive)
UIStore-->>ModelSelector: "icons"
ModelSelector->>FilterTabs: Re-render with provider icons
FilterTabs-->>User: Display icons instead of names
Note over User,FilterTabs: Page Refresh
User->>ModelSelector: Open model selector
UIStore->>LocalStorage: Load persisted filterStyle
LocalStorage-->>UIStore: Return "icons"
ModelSelector->>UIStore: Read filterStyle
UIStore-->>ModelSelector: "icons"
ModelSelector->>FilterTabs: Render provider icons
FilterTabs-->>User: Preference persisted
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4 files reviewed, 1 comment
| {filterStyle === "icons" ? ( | ||
| <ProviderLogo providerId={provider.logoId} className="size-4" /> | ||
| ) : null} | ||
| <span className="max-w-[80px] truncate">{provider.name}</span> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: when icons are hidden, the text label still displays but without the icon spacing
this creates inconsistent visual alignment since the button's layout doesn't fully account for icon-less state
| {filterStyle === "icons" ? ( | |
| <ProviderLogo providerId={provider.logoId} className="size-4" /> | |
| ) : null} | |
| <span className="max-w-[80px] truncate">{provider.name}</span> | |
| {filterStyle === "icons" && ( | |
| <ProviderLogo providerId={provider.logoId} className="size-4" /> | |
| )} |
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
- Change filter setting from names/icons to company/model name toggle - Icons (provider logos) are now always shown in filter tabs - Add modelName field (e.g., "GPT", "Claude", "Llama") for model-name mode - Default to model names as requested in #548 comments Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Mobile filter tabs now show icon-only buttons like the desktop sidebar, with provider name available as tooltip on long-press. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Summary
Fixes the issues raised in #548 comments — users can now choose their preferred filter display style, and the default shows text names as requested.
Test plan
🤖 Generated with Claude Code