Skip to content

fix: prevent authenticated users from accessing sign-in page and fix UI overflow #549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
leoisadev8 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: prevent authenticated users from accessing sign-in page and fix UI overflow #549

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions apps/web/src/routes/auth/sign-in.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
*/

import { useState, useEffect } from "react";
import { createFileRoute, Link } from "@tanstack/react-router";
import { signInWithGitHub, signInWithVercel } from "@/lib/auth-client";
import { createFileRoute, Link, useNavigate } from "@tanstack/react-router";
import { signInWithGitHub, signInWithVercel, useAuth } from "@/lib/auth-client";
import { Button } from "@/components/ui/button";
import { cn } from "@/lib/utils";
import { env } from "@/lib/env";
Expand Down Expand Up @@ -159,10 +159,19 @@ let cacheTimestamp = 0;
const CACHE_TTL = 5 * 60 * 1000; // 5 minutes

function SignInPage() {
const navigate = useNavigate();
const { isAuthenticated, loading } = useAuth();
const [isGitHubLoading, setIsGitHubLoading] = useState(false);
const [isVercelLoading, setIsVercelLoading] = useState(false);
const [stats, setStats] = useState<PublicStats | null>(cachedStats);

// Redirect if already authenticated
useEffect(() => {
if (!loading && isAuthenticated) {
navigate({ to: "/" });
}
}, [loading, isAuthenticated, navigate]);

// Fetch real stats from backend (cached)
useEffect(() => {
// Use cache if fresh
Expand Down Expand Up @@ -215,7 +224,7 @@ function SignInPage() {
};

return (
<div className="grid min-h-svh lg:grid-cols-2">
<div className="grid min-h-svh lg:grid-cols-2 overflow-hidden">
{/* Left Column - Sign In Form */}
<div className="flex flex-col gap-4 p-6 md:p-10">
<div className="flex justify-center gap-2 md:justify-start">
Expand Down