-
-
Notifications
You must be signed in to change notification settings - Fork 0
feat:Update OpenAPI spec for CreateOpenAIEncoderRequest and Encoder schemas #49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe changes update the OpenAPI specification in Changes
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/libs/Vectara/openapi.yaml (1)
4430-4438: Refined Name and Description Properties in CreateOpenAIEncoderRequest
Thenameproperty now clearly states “A unique name for the encoder” and its example has been updated to “openai-text-encoder”. This change improves clarity and enforces a consistent naming convention.Additionally, the
descriptionproperty’s example has been updated to the generic value “description”. While this generalization may match the intent of simplifying the example, consider whether a more descriptive example (e.g. “A transformer-based embedding encoder”) might better inform API consumers about what value is expected.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (2)
src/libs/Vectara/Generated/Vectara.Models.CreateOpenAIEncoderRequest.g.csis excluded by!**/generated/**src/libs/Vectara/Generated/Vectara.Models.Encoder.g.csis excluded by!**/generated/**
📒 Files selected for processing (1)
src/libs/Vectara/openapi.yaml(2 hunks)
🔇 Additional comments (1)
src/libs/Vectara/openapi.yaml (1)
4466-4479: Updated Encoder Schema Values for Consistency
- The
nameproperty in the Encoder schema now uses the example “openai-text-encoder” instead of a legacy value (previously “boomerang-2023-q3”), which aligns the public documentation with the new OpenAI-compatible encoder profile.- The
typeproperty’s example has been updated to “openai-compatible”. However, note that the default value remains set to “vectara”. This discrepancy might confuse API consumers—please verify if the intent is to use “openai-compatible” as the illustrative example while retaining a legacy default, or whether the default should be updated as well for consistency.- The
output_dimensionsexample has been updated to 1536, which is consistent with the new guidelines.
Summary by CodeRabbit