-
-
Notifications
You must be signed in to change notification settings - Fork 0
feat:Add qwen_image and gemini_25_flash_image to TransformModel enum #64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughTwo new enum values, qwen_image and gemini_25_flash_image, were added to the TransformModel enum in src/libs/Recraft/openapi.yaml. No other paths or schemas were modified. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~7 minutes Poem
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/libs/Recraft/openapi.yaml (1)
862-863: Optional: document and version the change.
- Consider bumping
info.version(e.g., 0.0.2) to reflect the new public surface.- Add brief release notes and an example request using each new model in GenerateImage/TransformImage docs to aid integrators.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (1)
src/libs/Recraft/Generated/Recraft.Models.TransformModel.g.csis excluded by!**/generated/**
📒 Files selected for processing (1)
src/libs/Recraft/openapi.yaml(1 hunks)
🔇 Additional comments (2)
src/libs/Recraft/openapi.yaml (2)
862-863: LGTM: Enum additions are consistent and non-breaking.
qwen_imageandgemini_25_flash_imagefollow existing snake_case naming and placement withinTransformModel. Additive enum changes are backward-compatible at the API level.
862-863: Confirm backend routing and regenerate SDKs for all clients
- Verified C# client (
src/libs/Recraft/Generated/Recraft.Models.TransformModel.g.cs) includes
–TransformModel.QwenImage => "qwen_image"
–TransformModel.Gemini25FlashImage => "gemini_25_flash_image"- No TypeScript/JavaScript/Python SDK code referencing these values was found—please rerun your OpenAPI codegen (e.g., openapi-generator, oapi-codegen) for every supported language.
- Didn’t detect any explicit model‐routing logic (switch statements or lookup tables) handling
qwen_imageorgemini_25_flash_imagein backend/provider code—ensure your routing layer is updated accordingly.- After updating routing and regenerating all SDKs, test that requests using these new models succeed (no 4xx) and don’t silently fallback.
Summary by CodeRabbit
New Features
Documentation