-
-
Notifications
You must be signed in to change notification settings - Fork 0
feat:Wrap example under requestBody.value for /v1/streaming.create_token #57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe change updates an example object in src/libs/HeyGen/openapi.yaml: under /v1/streaming.create_token requestBody, the example is wrapped inside a value field. No endpoints, methods, or schemas were modified. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/libs/HeyGen/openapi.yaml (1)
532-533: Optional: Clarify whether the request body is required and/or must be an empty object.Right now, the schema is
type: objectwithout properties and the example is{}. If the API:
- accepts no payload, mark the requestBody as optional; or
- requires an explicitly empty JSON object, enforce it via schema.
Two suggested patterns (pick one):
- If body is optional (recommended if server ignores body):
requestBody: required: false content: application/json: schema: type: object examples: streaming.create_token: value: {}
- If body must be exactly
{}:requestBody: required: true content: application/json: schema: type: object additionalProperties: false # minProperties/maxProperties are supported by OAS 3.0 JSON Schema dialects minProperties: 0 maxProperties: 0 examples: streaming.create_token: value: {}
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
src/libs/HeyGen/openapi.yaml(1 hunks)
🔇 Additional comments (2)
src/libs/HeyGen/openapi.yaml (2)
532-533: Good fix: ExampleObject now correctly uses a value.Wrapping the example in
value: {}aligns with OpenAPI 3.x ExampleObject semantics and improves tooling compatibility (Swagger UI, codegen, Postman). No functional changes to the endpoint behavior.
532-533: Validate HeyGen OpenAPI specWe located and validated the spec at
src/libs/HeyGen/openapi.yaml:
- ✅ Spec is syntactically valid per
swagger-cli validate.- 🚨 The previous Redocly lint invocation was incorrect and needs to be run as shown below.
Please run the following and confirm there are no lint errors:
#!/bin/bash set -euo pipefail file="src/libs/HeyGen/openapi.yaml" # 1) Re-validate syntax npx --yes swagger-cli@4 validate "$file" # 2) Lint with Redocly CLI npx --yes @redocly/cli@1.18.1 lint "$file" || trueEnsure the lint step completes without errors to avoid regressions in downstream code generators.
Summary by CodeRabbit