-
-
Notifications
You must be signed in to change notification settings - Fork 0
feat:Add scoped JWT inspection and creation endpoints #125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe changes introduce two new endpoints in the OpenAPI specification for managing scoped JWTs. A Changes
Sequence Diagram(s)sequenceDiagram
participant C as Client
participant API as API Gateway
C->>API: GET /v1/scoped-jwt?jwtoken=<token> \nHeader: xi-api-key
API-->>C: 200 OK (InspectScopedJWTOut payload)
sequenceDiagram
participant C as Client
participant API as API Gateway
C->>API: POST /v1/scoped-jwt \nHeader: xi-api-key \nBody: ScopedJWTIn payload
API-->>C: 200 OK (ScopedJWTOut token)
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
src/libs/DeepInfra/openapi.yaml (2)
2662-2692: Review of GET /v1/scoped-jwt EndpointThe newly added GET endpoint for inspecting a scoped JWT is defined clearly with the required query parameter
jwtokenand thexi-api-keyheader. The response section correctly references theInspectScopedJWTOutschema for a successful response and uses the standardHTTPValidationErrorschema for validation errors.Suggestion: Consider standardizing the casing of the parameter title (e.g. using
JWTinstead ofJwtoken) so that it matches common industry nomenclature and any existing documentation.
2693-2721: Review of POST /v1/scoped-jwt EndpointThe POST endpoint for creating a scoped JWT is properly structured. It specifies a header parameter (
xi-api-key), uses a request body that references theScopedJWTInschema, and returns a response defined by theScopedJWTOutschema on success.Observations:
- The summary reads as
' Create Scoped Jwt'with an extra leading space and the casing “Jwt” is used instead of the more conventional “JWT”.- The operationId is prefixed with an underscore (
_create_scoped_jwt_v1_scoped_jwt_post), which is somewhat unconventional compared to other operationIds in the file. Please confirm if the underscore prefix was intended.These are minor issues but aligning naming conventions will improve overall readability and consistency.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (11)
src/libs/DeepInfra/Generated/DeepInfra.DeepInfraApi.CreateScopedJwt.g.csis excluded by!**/generated/**src/libs/DeepInfra/Generated/DeepInfra.DeepInfraApi.InspectScopedJwt.g.csis excluded by!**/generated/**src/libs/DeepInfra/Generated/DeepInfra.IDeepInfraApi.CreateScopedJwt.g.csis excluded by!**/generated/**src/libs/DeepInfra/Generated/DeepInfra.IDeepInfraApi.InspectScopedJwt.g.csis excluded by!**/generated/**src/libs/DeepInfra/Generated/DeepInfra.Models.InspectScopedJWTOut.Json.g.csis excluded by!**/generated/**src/libs/DeepInfra/Generated/DeepInfra.Models.InspectScopedJWTOut.g.csis excluded by!**/generated/**src/libs/DeepInfra/Generated/DeepInfra.Models.ScopedJWTIn.Json.g.csis excluded by!**/generated/**src/libs/DeepInfra/Generated/DeepInfra.Models.ScopedJWTIn.g.csis excluded by!**/generated/**src/libs/DeepInfra/Generated/DeepInfra.Models.ScopedJWTOut.Json.g.csis excluded by!**/generated/**src/libs/DeepInfra/Generated/DeepInfra.Models.ScopedJWTOut.g.csis excluded by!**/generated/**src/libs/DeepInfra/Generated/JsonSerializerContextTypes.g.csis excluded by!**/generated/**
📒 Files selected for processing (1)
src/libs/DeepInfra/openapi.yaml(3 hunks)
Summary by CodeRabbit