-
-
Notifications
You must be signed in to change notification settings - Fork 1
feat:Update LemurModel enum to remove duplicate and add new model identifier #98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe change updates the Changes
Estimated code review effort1 (~2 minutes) Poem
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
src/libs/AssemblyAI/Generated/AssemblyAI.Models.LemurModel.g.csis excluded by!**/generated/**
📒 Files selected for processing (1)
src/libs/AssemblyAI/openapi.yaml(1 hunks)
| - anthropic/claude-sonnet-4-20250514 | ||
| - anthropic/claude-opus-4-20250514 | ||
| - anthropic/claude-sonnet-4-20250514 | ||
| - anthropic/claude-3-7-sonnet-20250219 | ||
| - anthropic/claude-3-5-sonnet |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
🧩 Analysis chain
Provide enum metadata for the newly-added model.
The string value anthropic/claude-3-7-sonnet-20250219 is now part of the LemurModel enum, but it is missing the accompanying x-fern-enum and x-aai-enum entries that supply SDK casing rules and human-readable labels.
Without these blocks, downstream code-gen may either fall back to generic naming or, in strict modes, reject the spec.
@@ x-fern-enum:
+ anthropic/claude-3-7-sonnet-20250219:
+ description: >
+ Claude 3.7 Sonnet (released 2025-02-19). Offers balanced cost and
+ quality for medium-complexity tasks.
+ casing:
+ camel: anthropicClaude3_7_Sonnet_20250219
+ snake: anthropic_claude3_7_sonnet_20250219
+ pascal: AnthropicClaude3_7_Sonnet_20250219
+ screamingSnake: ANTHROPIC_CLAUDE3_7_SONNET_20250219
@@ x-aai-enum:
+ anthropic/claude-3-7-sonnet-20250219:
+ label: Claude 3.7 Sonnet (on Anthropic)Please add the two blocks directly after the existing anthropic/claude-3-haiku entries to keep the spec consistent.
After updating, re-generate / re-lint the SDKs to ensure the new model surfaces correctly.
🏁 Script executed:
#!/bin/bash
set -e
# Search for the specific model string in the enum list
echo "Occurrences of 'anthropic/claude-3-7-sonnet-20250219':"
rg -n "anthropic/claude-3-7-sonnet-20250219" src/libs/AssemblyAI/openapi.yaml || echo "Not found in file."
# Locate the x-fern-enum block and check for the model entry
echo -e "\nChecking within x-fern-enum for the model entry:"
rg -A5 -n "x-fern-enum:" src/libs/AssemblyAI/openapi.yaml | sed -n '/x-fern-enum:/,/^[[:space:]]*[^[:space:]]/p' | grep "anthropic/claude-3-7-sonnet-20250219" && echo "Entry exists" || echo "Entry missing"
# Locate the x-aai-enum block and check for the model entry
echo -e "\nChecking within x-aai-enum for the model entry:"
rg -A5 -n "x-aai-enum:" src/libs/AssemblyAI/openapi.yaml | sed -n '/x-aai-enum:/,/^[[:space:]]*[^[:space:]]/p' | grep "anthropic/claude-3-7-sonnet-20250219" && echo "Entry exists" || echo "Entry missing"Length of output: 873
Add missing enum metadata for anthropic/claude-3-7-sonnet-20250219
The model value is declared on line 5792 but lacks the required x-fern-enum and x-aai-enum entries. Please insert the following blocks immediately after the existing anthropic/claude-3-haiku entries in src/libs/AssemblyAI/openapi.yaml:
@@ x-fern-enum:
+ anthropic/claude-3-7-sonnet-20250219:
+ description: >
+ Claude 3.7 Sonnet (released 2025-02-19). Offers balanced cost and
+ quality for medium-complexity tasks.
+ casing:
+ camel: anthropicClaude3_7_Sonnet_20250219
+ snake: anthropic_claude3_7_sonnet_20250219
+ pascal: AnthropicClaude3_7_Sonnet_20250219
+ screamingSnake: ANTHROPIC_CLAUDE3_7_SONNET_20250219
@@ x-aai-enum:
+ anthropic/claude-3-7-sonnet-20250219:
+ label: Claude 3.7 Sonnet (on Anthropic)• File: src/libs/AssemblyAI/openapi.yaml
• Location: after the anthropic/claude-3-haiku entries under both x-fern-enum and x-aai-enum
After updating, please re-generate and lint the SDKs to verify the new model surfaces correctly.
Committable suggestion skipped: line range outside the PR's diff.
🤖 Prompt for AI Agents
In src/libs/AssemblyAI/openapi.yaml around lines 5790 to 5793, the enum value
anthropic/claude-3-7-sonnet-20250219 is missing the required x-fern-enum and
x-aai-enum metadata entries. To fix this, add the appropriate x-fern-enum and
x-aai-enum blocks for this model immediately after the existing
anthropic/claude-3-haiku entries in both enum sections. After making these
additions, regenerate and lint the SDKs to ensure the new model is correctly
included.
Summary by CodeRabbit