-
-
Notifications
You must be signed in to change notification settings - Fork 1
feat:Deprecate throttled_only and add new enum values to LemurModel schema #93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe OpenAPI specification was updated to deprecate the Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant API
Client->>API: GET /v2/transcript?throttled_only=...
API-->>Client: Returns transcripts (with 'throttled_only' parameter deprecated)
Note over Client,API: For LeMUR tasks, new model enums are now accepted
Poem
✨ Finishing Touches🧪 Generate Unit Tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🔭 Outside diff range comments (1)
src/libs/AssemblyAI/openapi.yaml (1)
216-223: Schema-level deprecation missingThe request-parameter has been marked
deprecated: true, but the corresponding field incomponents.schemas.ListTranscriptParams.properties.throttled_only(≈ lines 5157-5165) is still marked as active.
SDK generators (Fern / OpenAPI) read the schema, not the in-line parameter, when building typed clients; consumers will therefore still see the property as current.@@ throttled_only: x-label: Throttled only description: Only get throttled transcripts, overrides the status filter type: boolean default: false + deprecated: trueAdd the flag (and, ideally, a description of the replacement) to keep the contract consistent.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
src/libs/AssemblyAI/Generated/AssemblyAI.Models.LemurModel.g.csis excluded by!**/generated/**
📒 Files selected for processing (1)
src/libs/AssemblyAI/openapi.yaml(2 hunks)
| - anthropic/claude-sonnet-4-20250514 | ||
| - anthropic/claude-opus-4-20250514 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Enum values added but ancillary mappings were not updated
The two new models are now part of the canonical enum, yet the helper maps that many SDK generators rely on are missing entries:
x-fern-enum(≈ 5803-5862)x-aai-enum(≈ 5863-5879)
Without those, code-gen will fail or omit the members, breaking compile-time safety.
@@ x-fern-enum:
+ anthropic/claude-sonnet-4-20250514:
+ description: >
+ Claude Sonnet 4 – next-generation balanced model.
+ casing:
+ camel: anthropicClaudeSonnet4_20250514
+ snake: anthropic_claude_sonnet4_20250514
+ pascal: AnthropicClaudeSonnet4_20250514
+ screamingSnake: ANTHROPIC_CLAUDE_SONNET4_20250514
+ anthropic/claude-opus-4-20250514:
+ description: >
+ Claude Opus 4 – highest-accuracy 4-series model.
+ casing:
+ camel: anthropicClaudeOpus4_20250514
+ snake: anthropic_claude_opus4_20250514
+ pascal: AnthropicClaudeOpus4_20250514
+ screamingSnake: ANTHROPIC_CLAUDE_OPUS4_20250514
@@ x-aai-enum:
+ anthropic/claude-sonnet-4-20250514:
+ label: Claude Sonnet 4 (on Anthropic)
+ anthropic/claude-opus-4-20250514:
+ label: Claude Opus 4 (on Anthropic)Please add equivalent entries (and any casing you need) to keep the spec self-consistent.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| - anthropic/claude-sonnet-4-20250514 | |
| - anthropic/claude-opus-4-20250514 | |
| # File: src/libs/AssemblyAI/openapi.yaml | |
| # ─────────────────────────────────────────────────────────────────── | |
| # Add the two new Anthropic models into the helper maps so code-gen stays | |
| # in sync with the canonical enum under Line 5794–5795. | |
| x-fern-enum: | |
| # … existing model entries … | |
| anthropic/claude-sonnet-4-20250514: | |
| description: > | |
| Claude Sonnet 4 – next-generation balanced model. | |
| casing: | |
| camel: anthropicClaudeSonnet4_20250514 | |
| snake: anthropic_claude_sonnet4_20250514 | |
| pascal: AnthropicClaudeSonnet4_20250514 | |
| screamingSnake: ANTHROPIC_CLAUDE_SONNET4_20250514 | |
| anthropic/claude-opus-4-20250514: | |
| description: > | |
| Claude Opus 4 – highest-accuracy 4-series model. | |
| casing: | |
| camel: anthropicClaudeOpus4_20250514 | |
| snake: anthropic_claude_opus4_20250514 | |
| pascal: AnthropicClaudeOpus4_20250514 | |
| screamingSnake: ANTHROPIC_CLAUDE_OPUS4_20250514 | |
| x-aai-enum: | |
| # … existing model entries … | |
| anthropic/claude-sonnet-4-20250514: | |
| label: Claude Sonnet 4 (on Anthropic) | |
| anthropic/claude-opus-4-20250514: | |
| label: Claude Opus 4 (on Anthropic) |
🤖 Prompt for AI Agents
In src/libs/AssemblyAI/openapi.yaml around lines 5794 to 5879, two new enum
values were added but the corresponding helper mappings `x-fern-enum` and
`x-aai-enum` were not updated. To fix this, add equivalent entries for the new
models in both the `x-fern-enum` section (lines ~5803-5862) and the `x-aai-enum`
section (lines ~5863-5879), ensuring any necessary casing adjustments are made
to keep the spec consistent and maintain compile-time safety for SDK generators.
Summary by CodeRabbit
New Features
Deprecations
throttled_onlyfilter in transcript queries is now marked as deprecated.