-
-
Notifications
You must be signed in to change notification settings - Fork 1
feat:Refine /v2/upload endpoint schema for binary file uploads in OpenAPI spec #76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe OpenAPI specification file for the AssemblyAI library was updated to refine the definition of the Changes
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/libs/AssemblyAI/openapi.yaml (1)
49-52: Explicit binary schema clarification for upload endpoint
The new schema correctly defines theapplication/octet-streampayload as a binary string, which will improve client validation and codegen. Consider marking the request body as required and adding a brief description to guide implementers.Diff suggestion:
@@ -47,4 +47,6 @@ paths: - content: + required: true + content: application/octet-stream: schema: type: string format: binary + description: Binary data of the media file
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (3)
src/libs/AssemblyAI/Generated/AssemblyAI.ITranscriptClient.UploadFile.g.csis excluded by!**/generated/**src/libs/AssemblyAI/Generated/AssemblyAI.TranscriptClient.UploadFile.g.csis excluded by!**/generated/**src/libs/AssemblyAI/Generated/JsonSerializerContextTypes.g.csis excluded by!**/generated/**
📒 Files selected for processing (1)
src/libs/AssemblyAI/openapi.yaml(1 hunks)
Summary by CodeRabbit