-
-
Notifications
You must be signed in to change notification settings - Fork 1
feat:EU server note for redacted audio; Keyterms prompt limits by model #130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughUpdated OpenAPI spec descriptions: added EU server usage note to the Get redacted audio endpoint and revised Keyterms prompt limits to be model-specific. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/libs/AssemblyAI/openapi.yaml (1)
556-559: Replace “above” with “this request” and match EU-note toneVerified — single occurrence in src/libs/AssemblyAI/openapi.yaml (lines 556–559).
- <Note>To retrieve the redacted audio on the EU server, replace `api.assemblyai.com` with `api.eu.assemblyai.com` in the `GET` request above.</Note> + <Note>To retrieve redacted audio on our EU server, replace `api.assemblyai.com` with `api.eu.assemblyai.com` in this request.</Note>Optional: add https://api.eu.assemblyai.com to top-level servers.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (3)
src/libs/AssemblyAI/Generated/AssemblyAI.ITranscriptClient.GetRedactedAudio.g.csis excluded by!**/generated/**src/libs/AssemblyAI/Generated/AssemblyAI.Models.Transcript.g.csis excluded by!**/generated/**src/libs/AssemblyAI/Generated/AssemblyAI.TranscriptClient.GetRedactedAudio.g.csis excluded by!**/generated/**
📒 Files selected for processing (1)
src/libs/AssemblyAI/openapi.yaml(2 hunks)
🔇 Additional comments (1)
src/libs/AssemblyAI/openapi.yaml (1)
2883-2891: Clarify model‑specific Keyterms limits and keep both descriptions in sync.Make the limits explicit and ensure both keyterms_prompt descriptions in src/libs/AssemblyAI/openapi.yaml (occurrences near lines 1475 and 2883) are identical.
- description: | - Improve accuracy with up to 200 (for Universal) or 1000 (for Slam-1) domain-specific words or phrases (maximum 6 words per phrase). + description: | + Improve accuracy with up to 200 domain‑specific words or phrases when using the Universal model, or up to 1000 when using Slam‑1. Each phrase may include up to 6 words.
Summary by CodeRabbit