-
-
Notifications
You must be signed in to change notification settings - Fork 1
feat:Refactor LemurTaskParams schema to remove inheritance and add required fields #107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🔭 Outside diff range comments (1)
src/libs/AssemblyAI/openapi.yaml (1)
5643-5656: Potentially breaking removal ofcontextand duplicated definition of inherited propsBy in-lining
transcript_idshere and dropping theallOf: $ref: LemurBaseParamsyou have silently lost thecontextproperty (and the optionaladditionalPropertiesguard) that downstream clients may still rely on.
If the intention is merely to make required fields explicit, keep the inheritance and overriderequired, or addcontextback explicitly.+ context: + x-label: Context + description: Context to provide the model. This can be a string or a free-form JSON value. + oneOf: + - type: string + - type: object + additionalProperties: true
🧹 Nitpick comments (1)
src/libs/AssemblyAI/openapi.yaml (1)
5676-5685: Redundant range ontemperatureA numeric
type: numberwithminimum/maximumis sufficient; specifyingformat: floatis superfluous in OpenAPI 3.1 and confuses some tooling (e.g.openapi-generator).
Safe to drop:- format: float
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (3)
src/libs/AssemblyAI/Generated/AssemblyAI.JsonConverters.LemurTaskParams.g.csis excluded by!**/generated/**src/libs/AssemblyAI/Generated/AssemblyAI.Models.LemurTaskParams.g.csis excluded by!**/generated/**src/libs/AssemblyAI/Generated/AssemblyAI.Models.LemurTaskParamsVariant1.g.csis excluded by!**/generated/**
📒 Files selected for processing (1)
src/libs/AssemblyAI/openapi.yaml(1 hunks)
🔇 Additional comments (1)
src/libs/AssemblyAI/openapi.yaml (1)
5663-5670:final_modelnow usesoneOfinstead of the originalanyOfChanging from
anyOftooneOfnarrows validation semantics (previously arbitrary strings were allowed).
Confirm this will not reject existing requests that pass custom model IDs.If broad compatibility is still desired, keep
anyOf:- oneOf: + anyOf:
| x-label: Maximum output size | ||
| description: Max output size in tokens, up to 4000 | ||
| type: integer | ||
| default: 2000 | ||
| temperature: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Missing maximum: 4000 on max_output_size
The description says “up to 4000” but the schema omits an explicit maximum.
Add the bound so generators & validators catch oversize values.
type: integer
default: 2000
+ maximum: 4000📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| x-label: Maximum output size | |
| description: Max output size in tokens, up to 4000 | |
| type: integer | |
| default: 2000 | |
| temperature: | |
| x-label: Maximum output size | |
| description: Max output size in tokens, up to 4000 | |
| type: integer | |
| default: 2000 | |
| maximum: 4000 | |
| temperature: |
🤖 Prompt for AI Agents
In src/libs/AssemblyAI/openapi.yaml around lines 5671 to 5675, the
max_output_size property lacks an explicit maximum constraint despite the
description stating "up to 4000". Add a maximum: 4000 field to the
max_output_size schema to enforce this upper bound in validation and code
generation.
Pull request was closed
Summary by CodeRabbit