-
-
Notifications
You must be signed in to change notification settings - Fork 1
feat:Flatten LemurTaskParams schema by embedding LemurBaseParams properties #106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe schema for Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~7 minutes Poem
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🔭 Outside diff range comments (1)
src/libs/AssemblyAI/openapi.yaml (1)
5641-5647:contextfield silently dropped – this is an un-documented breaking change
LemurTaskParamspreviously inheritedcontextthroughLemurBaseParams.
By flattening the schema but not re-addingcontext, the parameter is no longer accepted for the/lemur/v3/generate/taskendpoint.
Any client that relied on passing extra context will now fail validation at runtime.
Please either:
- Restore the field, or
- Explicitly document the removal and bump the API version.
prompt: x-label: Prompt description: Your text to prompt the model to produce a desired output, including any context you want to pass into the model. type: string + context: + x-label: Context + description: Context to provide the model. This can be a string or any free-form JSON value. + oneOf: + - type: string + - type: object + additionalProperties: true
🧹 Nitpick comments (1)
src/libs/AssemblyAI/openapi.yaml (1)
5647-5663: Schema duplication increases maintenance risk
transcript_idsandinput_textare now defined twice (here and inLemurBaseParams).
Any future tweak (e.g. description wording, limits) will have to be applied in two places and will diverge easily.Prefer keeping a single source of truth – e.g. keep the
allOf: [$ref: LemurBaseParams]and override only the few fields that really need to differ, or extract these common properties into a reusable component.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (3)
src/libs/AssemblyAI/Generated/AssemblyAI.JsonConverters.LemurTaskParams.g.csis excluded by!**/generated/**src/libs/AssemblyAI/Generated/AssemblyAI.Models.LemurTaskParams.g.csis excluded by!**/generated/**src/libs/AssemblyAI/Generated/AssemblyAI.Models.LemurTaskParamsVariant1.g.csis excluded by!**/generated/**
📒 Files selected for processing (1)
src/libs/AssemblyAI/openapi.yaml(1 hunks)
🧰 Additional context used
🧬 Code Graph Analysis (1)
src/libs/AssemblyAI/openapi.yaml (2)
src/libs/AssemblyAI/Conversions/LemurTaskParams.cs (2)
struct(5-36)FromPrompt(25-35)src/libs/AssemblyAI/Conversions/LemurTaskParamsVariant1.cs (2)
FromPrompt(24-30)LemurTaskParamsVariant1(5-31)
🔇 Additional comments (1)
src/libs/AssemblyAI/openapi.yaml (1)
5664-5670: Restore string fallback forfinal_modelto preserve custom model supportIn
src/libs/AssemblyAI/openapi.yaml(around lines 5664–5670), thefinal_modelschema was changed from accepting either a knownLemurModelor an arbitrary string to only allowingLemurModel. Removing thestringbranch will break any callers supplying ad-hoc model IDs.If you intend to continue supporting custom model identifiers, please revert to:
- oneOf: - - $ref: "#/components/schemas/LemurModel" + anyOf: + - $ref: "#/components/schemas/LemurModel" + - type: stringOtherwise, confirm that disallowing arbitrary strings is an intentional breaking change.
Pull request was closed
Summary by CodeRabbit
New Features
Documentation