Skip to content

Bridgecrew fix config: AWS::KMS::Key.LogsKey and 2 more #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bridgecrew wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Bridgecrew fix config: AWS::KMS::Key.LogsKey and 2 more #67

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions cfngoat.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,6 +259,7 @@ Resources:
AWS: !Sub arn:aws:iam::${AWS::AccountId}:root
Action: kms:*
Resource: '*'
EnableKeyRotation: True

LogsKeyAlias:
Type: AWS::KMS::Alias
Expand Down Expand Up @@ -290,15 +291,13 @@ Resources:
MasterUserPassword: !Ref Password
MultiAZ: False
BackupRetentionPeriod: 0
StorageEncrypted: False
StorageEncrypted: True
MonitoringInterval: 0
PubliclyAccessible: True
Tags:
- Key: Name
Value: !Sub "${AWS::AccountId}-${CompanyName}-${Environment}-rds"
- Key: Environment
Value: !Sub "${AWS::AccountId}-${CompanyName}-${Environment}"

DefaultDBOptionGroup:
Type: AWS::RDS::OptionGroup
Properties:
Expand All @@ -310,7 +309,6 @@ Resources:
Value: !Sub "og-${AWS::AccountId}-${CompanyName}-${Environment}"
- Key: Environment
Value: !Sub "${AWS::AccountId}-${CompanyName}-${Environment}"

DefaultDBParameterGroup:
Type: AWS::RDS::DBParameterGroup
Properties:
Expand Down