Fix buffer threshold detection for server timestamps

[michaelbeutler]

Problem

Buffer threshold detection was only applied when options.Timestamp was provided, but not when LoRaCloud/Traxmate returned a timestamp in the response. This could cause missed buffered data detection.

Solution

• Refactored buffer threshold logic to check ANY timestamp (options OR server response)
• Unified timestamp handling with timestampForBufferedCheck variable
• Updated data structure selection to use hasAnyTimestamp instead of withTimestamp

Changes

• ✅ Buffer threshold now applies to server timestamps
• ✅ Consistent buffered feature detection
• ✅ Comprehensive test coverage (83.6% overall, 90.9% for main function)
• ✅ Added TestSolveServerTimestampBufferedLogic and TestSolveDataStructureSelection

Testing

• All existing tests pass
• New tests cover all timestamp combinations
• Critical logic paths have 100% coverage

[Copilot]

Pull Request Overview

This PR refactors buffer threshold detection to apply to any timestamp (from options or server response), not just when options.Timestamp is provided. This ensures buffered data detection is consistent regardless of timestamp source.

• Unified timestamp handling with timestampForBufferedCheck variable that works with both option and server timestamps
• Replaced withTimestamp checks with hasAnyTimestamp in data structure selection logic
• Added comprehensive test coverage for server timestamp buffered detection scenarios

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File	Description
pkg/solver/loracloud/v2/loracloud.go	Refactored buffer threshold logic to check any timestamp and updated data structure selection
pkg/solver/loracloud/v2/loracloud_test.go	Added comprehensive tests for server timestamp buffered logic and data structure selection

Comments suppressed due to low confidence (1)

pkg/solver/loracloud/v2/loracloud_test.go:1

• [nitpick] The inline anonymous function pattern for creating time pointers is repeated and reduces readability. Consider extracting this to a helper function like timePtr(duration time.Duration) *time.Time to make the test data more concise and maintainable.

package v2

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[sonarqubecloud]

Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud