-
Notifications
You must be signed in to change notification settings - Fork 0
Update GNSS port handling to always use port 192 in decoder and tests #161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR standardizes GNSS NAV grouping port handling in the TagXL v1 decoder to always use port 192, replacing the previous behavior that used the incoming port values (193, 194, or 195).
- Updates decoder logic to hardcode port 192 for GNSS NAV grouping instead of using incoming port values
- Updates test expectations to align with the new standardized port 192 behavior
- Ensures consistency across all GNSS-related functionality by centralizing port handling
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| pkg/decoder/tagxl/v1/decoder.go | Changes GNSS NAV grouping to always use port 192 instead of incoming port value |
| pkg/decoder/tagxl/v1/examples_test.go | Updates test assertions to expect port 192 for ports 194 and 195 test cases |
| pkg/decoder/tagxl/v1/gnss_v2_test.go | Updates test assertions to expect port 192 for ports 193, 194, and 195 test cases |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
KangooGuy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In line with new payload format.
|



This pull request standardizes the GNSS NAV grouping port to always use port 192 in the TagXL v1 decoder, replacing previous logic that used ports 193, 194, or 195. The associated tests have been updated to expect port 192 accordingly.
Port standardization for GNSS NAV grouping:
TagXLv1Decoder.Decodemethod indecoder.goto always set thePortfield to 192 for GNSS NAV grouping, instead of using the incoming port value.Test updates for port changes:
examples_test.goandgnss_v2_test.goto expect port 192 instead of 193, 194, or 195, ensuring alignment with the new decoder logic:TestTagXL_GNSS_Port194_TimestampedandTestTagXL_GNSS_Port195_Timestampedto expect 192. [1] [2]TestGNSS_SolverV2_192_193_NoTimestampto expect 192.TestGNSS_SolverV2_194_195_TimestampStrippedAndPassedto expect 192 for both cases. [1] [2]