Skip to content

Conversation

@michaelbeutler
Copy link
Contributor

This pull request standardizes the GNSS NAV grouping port to always use port 192 in the TagXL v1 decoder, replacing previous logic that used ports 193, 194, or 195. The associated tests have been updated to expect port 192 accordingly.

Port standardization for GNSS NAV grouping:

  • Updated the TagXLv1Decoder.Decode method in decoder.go to always set the Port field to 192 for GNSS NAV grouping, instead of using the incoming port value.

Test updates for port changes:

  • Modified tests in examples_test.go and gnss_v2_test.go to expect port 192 instead of 193, 194, or 195, ensuring alignment with the new decoder logic:
    • Updated port checks in TestTagXL_GNSS_Port194_Timestamped and TestTagXL_GNSS_Port195_Timestamped to expect 192. [1] [2]
    • Updated port checks in TestGNSS_SolverV2_192_193_NoTimestamp to expect 192.
    • Updated port checks in TestGNSS_SolverV2_194_195_TimestampStrippedAndPassed to expect 192 for both cases. [1] [2]

@codecov
Copy link

codecov bot commented Sep 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

Files with missing lines Coverage Δ
pkg/decoder/tagxl/v1/decoder.go 85.12% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR standardizes GNSS NAV grouping port handling in the TagXL v1 decoder to always use port 192, replacing the previous behavior that used the incoming port values (193, 194, or 195).

  • Updates decoder logic to hardcode port 192 for GNSS NAV grouping instead of using incoming port values
  • Updates test expectations to align with the new standardized port 192 behavior
  • Ensures consistency across all GNSS-related functionality by centralizing port handling

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

File Description
pkg/decoder/tagxl/v1/decoder.go Changes GNSS NAV grouping to always use port 192 instead of incoming port value
pkg/decoder/tagxl/v1/examples_test.go Updates test assertions to expect port 192 for ports 194 and 195 test cases
pkg/decoder/tagxl/v1/gnss_v2_test.go Updates test assertions to expect port 192 for ports 193, 194, and 195 test cases

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link

@KangooGuy KangooGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In line with new payload format.

@sonarqubecloud
Copy link

@michaelbeutler michaelbeutler merged commit 9a678d5 into main Sep 24, 2025
2 of 3 checks passed
@michaelbeutler michaelbeutler deleted the fix/tagxl-static-port branch September 24, 2025 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants