Lua: Fix stack level after register odkim functions. #201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When luaL_setfuncs() is replaced by luaL_newlib() + lua_setglobal() in commit 74b3374, the commit did not take account that lua_setglobal() pops a value from the stack. Thus, following lua pop(l, 1) tries to pop from empty stack in Lua >= 5.2, especially in Lua 5.4, it causes abort(). This fix it. * miltertest/miltertest.c (main): Don't pop after lua_setglobal() in Lua >= 5.2 * opendkim/opendkim-lua.c (dkimf_lua_setup_hook, dkimf_lua_screen_hook, dkimf_lua_stats_hook, dkimf_lua_final_hook): As above.
futatuki
added a commit
to futatuki/OpenDKIM
that referenced
this pull request
Feb 27, 2024
futatuki
added a commit
to futatuki/OpenDKIM
that referenced
this pull request
Apr 26, 2024
…tack Lua: Fix starck level after registration of odkim functions.
futatuki
added a commit
to futatuki/OpenDKIM
that referenced
this pull request
Apr 26, 2024
yasuhirokimura
pushed a commit
to yasuhirokimura/freebsd-ports
that referenced
this pull request
Jun 20, 2024
PR: 279811 Reported by: Yasuhito FUTATSUKI Obtained from: trusteddomainproject/OpenDKIM#201
yasuhirokimura
pushed a commit
to yasuhirokimura/freebsd-ports
that referenced
this pull request
Jun 21, 2024
PR: 279811 Reported by: Yasuhito FUTATSUKI Obtained from: trusteddomainproject/OpenDKIM#201
yasuhirokimura
pushed a commit
to yasuhirokimura/freebsd-ports
that referenced
this pull request
Jun 21, 2024
PR: 279811 Reported by: Yasuhito FUTATSUKI Obtained from: trusteddomainproject/OpenDKIM#201
yasuhirokimura
pushed a commit
to yasuhirokimura/freebsd-ports
that referenced
this pull request
Jun 21, 2024
PR: 279811 Reported by: Yasuhito FUTATSUKI Obtained from: trusteddomainproject/OpenDKIM#201
freebsd-git
pushed a commit
to freebsd/freebsd-ports
that referenced
this pull request
Jun 21, 2024
PR: 279811 Reported by: Yasuhito FUTATSUKI Obtained from: trusteddomainproject/OpenDKIM#201
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When luaL_setfuncs() is replaced by luaL_newlib() + lua_setglobal() in commit 74b3374, the commit did not take account that lua_setglobal() pops a value from the stack.
Thus, following lua pop(l, 1) tries to pop from empty stack in Lua >= 5.2, especially in Lua 5.4, it causes abort().
This fix it.
miltertest/miltertest.c (main): Don't pop after lua_setglobal() in Lua >= 5.2
opendkim/opendkim-lua.c (dkimf_lua_setup_hook, dkimf_lua_screen_hook, dkimf_lua_stats_hook, dkimf_lua_final_hook): As above.