fix(bundle): resolve OLM installation and runtime errors #113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Jakob-Naucke
left a comment
Jakob-Naucke
left a comment
There was a problem hiding this comment.
before testing: can we also drop USER nobody from ./Containerfile (aka the operator containerfile) for consistency?
Contributor
Jakob-Naucke
left a comment
Jakob-Naucke
left a comment
There was a problem hiding this comment.
otherwise, tested & LGTM
yalzhang
force-pushed
the
fix_bundle
branch
2 times, most recently
from
59342f6 to
31db15e
Compare
Contributor
Author
|
Tested scenarios below and the resule is expected, attestation pass, vm boot successfully:
|
Jakob-Naucke
approved these changes
Dec 22, 2025
Contributor
Jakob-Naucke
left a comment
Jakob-Naucke
left a comment
There was a problem hiding this comment.
one nit, but can already approve
This commit fixes issues that prevented the operator from installing and running correctly via an OLM bundle. Key changes: - Use `clusterPermissions` in CSV to ensure correct cluster-wide RBAC. - Automate RBAC manifests copying and namespace patching in the bundle. - Remove `USER nobody` from Containerfiles to avoid runtime permission errors. Signed-off-by: Yalan Zhang <yalzhang@redhat.com>
Contributor
Author
|
Have ran the integration test and with libvirt vm, the result is as expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes issues that prevented the operator from installing and running correctly via an OLM bundle.
Key changes:
clusterPermissionsin CSV to ensure correct cluster-wide RBAC.USER nobodyfrom Containerfiles to avoid runtime permission errors.