add creator MCP registry discovery and toolkit cataloging#610
add creator MCP registry discovery and toolkit cataloging#610shaunak99 wants to merge 1 commit intotruffle-ai:mainfrom
Conversation
|
@shaunak99 is attempting to deploy a commit to the Shaunak's projects Team on Vercel. A member of the Team first needs to authorize it. |
📝 WalkthroughWalkthroughThis change introduces toolkit type discovery across the agent system by propagating Changes
Possibly related PRs
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
packages/core/src/agent/agent-options.ts (1)
59-64: Prefer makingavailableToolkitTypesnon-optional at the options boundary.Keeping this optional can force fallback handling downstream for a value that is now resolver-derived. Consider requiring it and defaulting at boundary adapters.
♻️ Suggested refactor
- availableToolkitTypes?: string[] | undefined; + availableToolkitTypes: string[];As per coding guidelines, avoid optional/fallback chains and prefer a single source of truth for runtime values.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@packages/core/src/agent/agent-options.ts` around lines 59 - 64, The AgentOptions field availableToolkitTypes is currently optional, which forces downstream fallback handling; change the AgentOptions declaration to make availableToolkitTypes a non-optional string[] (remove the optional marker and undefined union) and ensure every options/adapter that constructs or resolves AgentOptions (e.g., the boundary adapters or resolver that currently derive toolkit types) populates a default (e.g., an empty array or computed list) before creating AgentOptions so callers can rely on a single source-of-truth non-null array; update any call sites that assumed undefined to use the array form.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@packages/core/src/agent/agent-options.ts`:
- Around line 59-64: The AgentOptions field availableToolkitTypes is currently
optional, which forces downstream fallback handling; change the AgentOptions
declaration to make availableToolkitTypes a non-optional string[] (remove the
optional marker and undefined union) and ensure every options/adapter that
constructs or resolves AgentOptions (e.g., the boundary adapters or resolver
that currently derive toolkit types) populates a default (e.g., an empty array
or computed list) before creating AgentOptions so callers can rely on a single
source-of-truth non-null array; update any call sites that assumed undefined to
use the array form.
ℹ️ Review info
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (12)
.agents/skills/create-skill/SKILL.mdpackages/agent-config/src/resolver/resolve-services-from-config.tspackages/agent-config/src/resolver/to-dexto-agent-options.test.tspackages/agent-config/src/resolver/to-dexto-agent-options.tspackages/agent-config/src/resolver/types.tspackages/agent-management/package.jsonpackages/agent-management/src/tool-factories/creator-tools/factory.tspackages/agent-management/src/tool-factories/creator-tools/mcp-registry-catalog-tool.test.tspackages/agent-management/src/tool-factories/creator-tools/schemas.tspackages/agent-management/src/tool-factories/creator-tools/tool-catalog-tool.test.tspackages/core/src/agent/DextoAgent.tspackages/core/src/agent/agent-options.ts
Summary by CodeRabbit
New Features
Documentation