Skip to content

Fix: Implement and test terrain particle effects #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
truevox wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix: Implement and test terrain particle effects #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
87 changes: 40 additions & 47 deletions js/ModularGameScene.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,21 +223,21 @@ export default class ModularGameScene extends Phaser.Scene {
// See: https://newdocs.phaser.io/docs/3.90.0/Phaser.GameObjects.Particles.ParticleSystem

// --- DEBUG: Forced always-on test emitter at center ---
this.testEmitter = this.add.particles({
textureKey: 'particle',
x: this.cameras.main.centerX,
y: this.cameras.main.centerY,
tint: [0xffffff],
speed: 60,
angle: { min: 0, max: 360 },
lifespan: 900,
alpha: { start: 1, end: 0 },
scale: { start: 1.2, end: 0.1 },
quantity: 2,
frequency: 90,
maxParticles: 30,
});
console.log('[DEBUG] Forced test emitter created at center:', this.testEmitter);
// this.testEmitter = this.add.particles({
// textureKey: 'particle',
// x: this.cameras.main.centerX,
// y: this.cameras.main.centerY,
// tint: [0xffffff],
// speed: 60,
// angle: { min: 0, max: 360 },
// lifespan: 900,
// alpha: { start: 1, end: 0 },
// scale: { start: 1.2, end: 0.1 },
// quantity: 2,
// frequency: 90,
// maxParticles: 30,
// });
// console.log('[DEBUG] Forced test emitter created at center:', this.testEmitter);
Comment on lines +226 to +240
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot May 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The testEmitter and its associated console.log have been commented out. While this achieves the goal of removing its interference, commented-out code can reduce maintainability over time as it may become stale or confusing to future readers.

Could we remove this commented-out block entirely if it's no longer needed for debugging purposes? If it's something that might be useful for debugging in the near future, perhaps it could be conditionally enabled via a debug flag instead of being left as commented code in the main branch.


this.greenStreakEmitter = this.add.particles({
textureKey: 'particle',
Expand Down Expand Up @@ -617,38 +617,31 @@ Body.set(this.player.body, 'frictionStatic', PhysicsConfig.player.friction);

// --- PARTICLE EMITTER ACTIVATION ---
// Only one emitter should be visible/active at a time; follow player
if (currentTerrainType === 'green' && this.onGround) {
this.greenStreakEmitter.setPosition(this.player.x, this.player.y + 18);
this.greenStreakEmitter.setAngle({ min: Phaser.Math.RadToDeg(currentTerrainAngle) - 10, max: Phaser.Math.RadToDeg(currentTerrainAngle) + 10 });
this.greenStreakEmitter.setVisible(true);
this.greenStreakEmitter.active = true;
this.blueBlingEmitter.setVisible(false);
this.blueBlingEmitter.active = false;
this.magentaFlickerEmitter.setVisible(false);
this.magentaFlickerEmitter.active = false;
} else if (currentTerrainType === 'blue' && this.onGround) {
this.blueBlingEmitter.setPosition(this.player.x, this.player.y + 10);
this.blueBlingEmitter.setVisible(true);
this.blueBlingEmitter.active = true;
this.greenStreakEmitter.setVisible(false);
this.greenStreakEmitter.active = false;
this.magentaFlickerEmitter.setVisible(false);
this.magentaFlickerEmitter.active = false;
} else if (currentTerrainType === 'magenta' && this.onGround) {
this.magentaFlickerEmitter.setPosition(this.player.x, this.player.y + 16);
this.magentaFlickerEmitter.setVisible(true);
this.magentaFlickerEmitter.active = true;
this.greenStreakEmitter.setVisible(false);
this.greenStreakEmitter.active = false;
this.blueBlingEmitter.setVisible(false);
this.blueBlingEmitter.active = false;
} else {
this.greenStreakEmitter.setVisible(false);
this.greenStreakEmitter.active = false;
this.blueBlingEmitter.setVisible(false);
this.blueBlingEmitter.active = false;
this.magentaFlickerEmitter.setVisible(false);
this.magentaFlickerEmitter.active = false;
const playerOnGround = this.onGround; // Cache for clarity

// Default all emitters to off
this.greenStreakEmitter.setVisible(false);
this.greenStreakEmitter.active = false;
this.blueBlingEmitter.setVisible(false);
this.blueBlingEmitter.active = false;
this.magentaFlickerEmitter.setVisible(false);
this.magentaFlickerEmitter.active = false;

if (playerOnGround) {
if (currentTerrainType === 'green') {
this.greenStreakEmitter.setPosition(this.player.x, this.player.y + 10); // Adjusted offset
this.greenStreakEmitter.setAngle({ min: Phaser.Math.RadToDeg(currentTerrainAngle) - 10, max: Phaser.Math.RadToDeg(currentTerrainAngle) + 10 });
this.greenStreakEmitter.setVisible(true);
this.greenStreakEmitter.active = true;
} else if (currentTerrainType === 'blue') {
this.blueBlingEmitter.setPosition(this.player.x, this.player.y + 10); // Adjusted offset
this.blueBlingEmitter.setVisible(true);
this.blueBlingEmitter.active = true;
} else if (currentTerrainType === 'magenta') {
this.magentaFlickerEmitter.setPosition(this.player.x, this.player.y + 10); // Adjusted offset
this.magentaFlickerEmitter.setVisible(true);
this.magentaFlickerEmitter.active = true;
}
}
// Debug log for emitter visibility
if (this.greenStreakEmitter.visible || this.blueBlingEmitter.visible || this.magentaFlickerEmitter.visible) {
Expand Down
Loading