NAS-139176 / 26.04 / update directory listing to use decrypted names if available

[stavros-k]

The decrypted field is the decrypted file name, not whether is decrypted or not.

If it has decrypted name, use that.

A backport to 25.10.2 would be nice!

---

Before:

After:

[claude]

Claude finished @stavros-k's task —— View job

---

Code Review Complete ✅

Great fix! The change correctly interprets the Decrypted field as containing the decrypted filename rather than being a boolean flag. The implementation is consistent across all three affected components.

---

🎯 Key Issue Identified

The Decrypted field should be optional ⚠️

The interface currently defines Decrypted as a required string:

Decrypted?: string;  // Already marked optional in latest commit

However, based on the review comments and the implementation pattern (file.Decrypted ? file.Decrypted : file.Name), this field may not always be present. The middleware reference you linked shows this field is only populated when files are encrypted and successfully decrypted.

Status: ✅ This has already been addressed in the review comments and the interface correctly marks it as optional.

---

✨ What's Working Well

• Consistent implementation: All three components use the identical pattern for handling decrypted names
• Proper fallback logic: Using the ternary operator file.Decrypted ? file.Decrypted : file.Name ensures graceful fallback to the original name
• Clear comment: The interface comment clearly explains what the field contains

---

📝 Test Coverage Note

The codecov report shows 0% coverage for the changed lines. While this PR's logic is straightforward, the lack of tests for the cloudsync.list_directory API response handling means:

• No validation that decrypted names are displayed correctly
• No test coverage for the fallback behavior when Decrypted is absent
• No protection against future regressions

Recommendation: Consider adding integration tests or component tests that mock the cloudsync.list_directory response with both encrypted (with Decrypted field) and non-encrypted files to verify the correct display behavior.

---

🔍 Type Safety Consideration

All three implementations use the same safe pattern:

name: file.Decrypted ? file.Decrypted : file.Name

Since Decrypted is now correctly marked as optional (Decrypted?: string), TypeScript will properly handle the case where it's undefined. The ternary operator provides appropriate runtime safety. 👍

---

Summary

This is a solid bug fix that correctly addresses the misinterpretation of the Decrypted field. The implementation is consistent, safe, and includes proper fallback logic. The main area for improvement is test coverage to ensure this behavior is maintained in future changes.

[stavros-k]

https://github.com/truenas/middleware/blob/99fed3a66a0b9bbc48854fe443ce5f0739e3f8b4/src/middlewared/middlewared/plugins/cloud_sync.py#L949

[codecov]

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.69%. Comparing base (28b3164) to head (2381baa).
⚠️ Report is 4 commits behind head on master.
✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
...p/cloud-backup-form/cloud-backup-form.component.ts	0.00%	1 Missing ⚠️
...oudsync/cloudsync-form/cloudsync-form.component.ts	0.00%	1 Missing ⚠️
...what-and-when/cloudsync-what-and-when.component.ts	0.00%	1 Missing ⚠️

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #13058      +/-   ##
==========================================
- Coverage   86.69%   86.69%   -0.01%     
==========================================
  Files        1847     1847              
  Lines       69413    69416       +3     
  Branches     8584     8587       +3     
==========================================
+ Hits        60178    60180       +2     
- Misses       9235     9236       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[Copilot]

Pull request overview

This PR refactors the directory listing functionality to properly handle decrypted file names. The key change is correcting the interpretation of the Decrypted field from a boolean flag to a string containing the decrypted name. When available, the decrypted name is now displayed in the UI instead of the encrypted name, improving user experience for cloud sync and backup operations with encrypted filenames.

Key Changes:

• Updated CloudSyncDirectoryListing interface to define Decrypted as a string type instead of boolean
• Modified directory listing logic in three components to display decrypted names when available, falling back to the original name

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File	Description
src/app/interfaces/cloud-sync-task.interface.ts	Updated Decrypted field type from boolean to string and added clarifying comment
src/app/pages/data-protection/cloudsync/cloudsync-wizard/steps/cloudsync-what-and-when/cloudsync-what-and-when.component.ts	Updated directory node creation to use decrypted name when available
src/app/pages/data-protection/cloudsync/cloudsync-form/cloudsync-form.component.ts	Updated directory node creation to use decrypted name when available
src/app/pages/data-protection/cloud-backup/cloud-backup-form/cloud-backup-form.component.ts	Updated directory node creation to use decrypted name when available

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[AlexKarpov98]

👍

[bugclerk]

Jira URL: https://ixsystems.atlassian.net/browse/NAS-139176

[bugclerk]

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.