Seed NVMe SMART flags from canonical interface

[ralequi]

Summary

• reset Device defaults for SMART capability, enablement, and SSD status instead of special-casing NVMe-derived interfaces
• rely on the canonical interface returned by _classify during update() to flag NVMe devices (including ASMedia bridges) as SMART-capable SSDs
• drop the now-unnecessary _interface shortcut that previously toggled the NVMe defaults during interface probing

Testing

• pip install .
• pytest

---

https://chatgpt.com/codex/tasks/task_e_68dd1e61b4e0832fa014ceacb486f993

[Copilot]

Pull Request Overview

This PR refactors NVMe device detection and SMART capability assignment to use the canonical interface classification instead of early interface-specific defaults. The change ensures that NVMe devices accessed through bridge interfaces like ASMedia are properly flagged as SMART-capable SSDs.

• Removes hardcoded NVMe defaults during device initialization and interface probing
• Adds canonical interface mapping for ASMedia bridge (sntasmedia → nvme)
• Sets SMART flags based on canonical interface during the update process

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
pySMART/device.py	Updated device initialization defaults and classification logic
pySMART/utils.py	Added sntasmedia interface mapping
tests/dataset/singletests/nvme_usb_asmedia_issue_97/device.json	Test data for ASMedia NVMe device
tests/dataset/singletests/nvme_usb_asmedia_issue_97/-d_sntasmedia--all__dev_sda	Raw smartctl output for test case
tests/dataset/listingtests/linux_usb_nvme_asmedia_issue_97/device.json	Test data for device listing
tests/dataset/listingtests/linux_usb_nvme_asmedia_issue_97/-d_sntasmedia--all__dev_sda	Raw smartctl output for listing test
tests/dataset/listingtests/linux_usb_nvme_asmedia_issue_97/_--scan-open	Device scan output

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[ralequi]

@codex please, mention #97 and its creator on the futute release notes as I've been done in other cases

[chatgpt-codex-connector]

Summary

• Added an unreleased changelog entry to acknowledge issue ValueError: Unknown interface: sntasmedia specified for /dev/sda #97 and thank @hille721 in future release notes. CHANGELOG.mdL1-L3

Testing

• ⚠️ Not run (not requested)

View task →

[Copilot]

Pull Request Overview

Copilot reviewed 12 out of 13 changed files in this pull request and generated 1 comment.

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[Copilot]

The variable name canonical_interface is misleading since it's assigned self.dev_interface but the comment and PR description suggest it should use the result from _classify(). Either use self._classify() or rename the variable to reflect it's using dev_interface.

[ralequi]

@copilot could you fix this for me?

[ralequi]

@coplilot please, mention #97 and its creator on the future release notes (1.4.2) as I've been done in other cases