Skip to content

Feat: generate the SDK V1.0.12 #9

Merged
patienceigiraneza merged 3 commits intomainfrom
features
Jun 20, 2025
Merged

Feat: generate the SDK V1.0.12 #9
patienceigiraneza merged 3 commits intomainfrom
features

Conversation

@patienceigiraneza
Copy link
Contributor

@patienceigiraneza patienceigiraneza commented Jun 20, 2025

PR Type

Enhancement


Description

• Bump SDK version from 1.0.11 to 1.0.12
• Add required response fields to OpenAPI specification


Changes walkthrough 📝

Relevant files
Configuration changes
config.json
Bump package version to 1.0.12                                                     

config.json

• Updated packageVersion from "1.0.11" to "1.0.12"

+1/-1     
Enhancement
openapi.yaml
Expand OpenAPI response schema requirements                           

openapi.yaml

• Added 8 new required response fields to schema
• Enhanced API
response specification with message, domain, DNS-related fields and
error handling

+9/-0     

Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.
  • @qodo-code-review
    Copy link

    You are nearing your monthly Qodo Merge usage quota. For more information, please visit here.

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Schema Validation

    Adding 8 new required fields to the response schema without defining their properties could break API consumers. The fields are marked as required but lack type definitions and descriptions.

    - message
    - domain
    - all_dns_score
    - found
    - total
    - missing_dns
    - other_missing_dns
    - found_dns
    - error

    @qodo-code-review
    Copy link

    qodo-code-review bot commented Jun 20, 2025

    You are nearing your monthly Qodo Merge usage quota. For more information, please visit here.

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Impact
    Possible issue
    Add missing property definitions

    The schema defines 10 required fields but only provides properties for score.
    All required fields should have corresponding property definitions with
    appropriate types and descriptions to ensure proper API documentation and
    validation.

    openapi.yaml [171-185]

     required:
     - score
     - message
     - domain
     - all_dns_score
     - found
     - total
     - missing_dns
     - other_missing_dns
     - found_dns
     - error
     type: object
     properties:
       score:
         type: number
    +  message:
    +    type: string
    +  domain:
    +    type: string
    +  all_dns_score:
    +    type: number
    +  found:
    +    type: integer
    +  total:
    +    type: integer
    +  missing_dns:
    +    type: array
    +    items:
    +      type: string
    +  other_missing_dns:
    +    type: array
    +    items:
    +      type: string
    +  found_dns:
    +    type: array
    +    items:
    +      type: string
    +  error:
    +    type: string
    • Apply / Chat
    Suggestion importance[1-10]: 9

    __

    Why: The suggestion correctly points out that the PR adds multiple fields to the required list in the OpenAPI schema but fails to define their corresponding properties. This is a critical omission, as it results in an incomplete and potentially invalid API specification, impacting documentation, validation, and client code generation.

    High
    • Update

    @patienceigiraneza patienceigiraneza merged commit 1b641b8 into main Jun 20, 2025
    10 checks passed
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    1 participant