Skip to content

Feat: Correct responsee stracture#10

Merged
patienceigiraneza merged 1 commit intomainfrom
features
Jun 21, 2025
Merged

Feat: Correct responsee stracture#10
patienceigiraneza merged 1 commit intomainfrom
features

Conversation

@patienceigiraneza
Copy link
Contributor

@patienceigiraneza patienceigiraneza commented Jun 21, 2025

PR Type

Bug fix


Description

  • Fix DNS response structure field types

  • Change missing_dns and other_missing_dns from object arrays to string arrays


Changes walkthrough 📝

Relevant files
Bug fix
dns_info_create200_response.py
Update DNS field types to string arrays                                   

workplace_client/models/dns_info_create200_response.py

  • Changed missing_dns field type from List[Dict[str, Any]] to
    List[StrictStr]
  • Changed other_missing_dns field type from List[Dict[str, Any]] to
    List[StrictStr]
  • +2/-2     
    openapi.yaml
    Fix OpenAPI schema DNS field types                                             

    openapi.yaml

  • Changed missing_dns array items type from object to string
  • Changed other_missing_dns array items type from object to string
  • +2/-2     
    Documentation
    DnsInfoCreate200Response.md
    Update DNS field documentation types                                         

    docs/DnsInfoCreate200Response.md

  • Updated documentation for missing_dns from List[object] to List[str]
  • Updated documentation for other_missing_dns from List[object] to
    List[str]
  • +2/-2     

    Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.
  • @qodo-code-review
    Copy link

    You are nearing your monthly Qodo Merge usage quota. For more information, please visit here.

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Breaking Change

    The type change from List[Dict[str, Any]] to List[StrictStr] for missing_dns and other_missing_dns fields is a breaking change that could affect existing code consuming this API response. Verify that all consumers can handle string arrays instead of object arrays.

    missing_dns: List[StrictStr]
    other_missing_dns: List[StrictStr]

    @qodo-code-review
    Copy link

    You are nearing your monthly Qodo Merge usage quota. For more information, please visit here.

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    @patienceigiraneza patienceigiraneza merged commit dd6776a into main Jun 21, 2025
    10 checks passed
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    1 participant