upstream changes

[willymwai]

PR Type

Tests, Enhancement, Bug fix, Configuration changes, Documentation, Formatting

---

Description

• Added and enhanced numerous Storybook stories for components like BaseComboBox, BaseListBox, BaseSelect, and more, improving test coverage and interaction testing.

• Migrated project creation from Create React App to Vite, updating configurations and CLI logic accordingly.

• Introduced new utilities and refactored existing ones for better modularity, type safety, and performance, such as toVariantKey for variant key handling and UUID-based repetition index tracking.

• Fixed various bugs, including issues with color handling in ColorButton and ColorPicker, and improved accessibility and behavior.

• Added ESLint and Vite configurations for React TypeScript and JavaScript projects, enhancing development workflows.

• Improved type definitions and integration for Plasmic canvas components across multiple files.

• Enhanced user interaction features, such as adding confirmation dialogs for deletion actions and improving zoom-to-fit functionality.

• Updated Storybook configurations to TypeScript and added SWC compiler for better performance.

• Removed deprecated features and simplified logic in several components for maintainability.

• Added new server query utilities and improved handling of server-side data.

• Made minor formatting changes for consistency and readability.

---

Changes walkthrough 📝

	Relevant files
Tests	18 files UseDollarState.stories.tsx Refactored stories and tests for UseDollarState.                  packages/react-web/src/stories/UseDollarState.stories.tsx Replaced Story with StoryFn for type consistency. Removed redundant sleep calls and replaced them with waitFor where necessary. Updated test assertions to use toBeInTheDocument for better clarity. Added tags like skip-test to some stories for conditional execution. +228/-279 Form.stories.tsx Enhanced Form stories with better abstraction and tagging. plasmicpkgs/antd5/src/stories/Form.stories.tsx Updated imports and replaced userEvent.type with justType for better abstraction. Added tags like skip-test to some stories for conditional execution. Improved test assertions with toBeInTheDocument for clarity. Adjusted test logic for form validation and interactions. +75/-76  registerComboBox.stories.tsx Added stories for BaseComboBox component with tests.          plasmicpkgs/react-aria/src/registerComboBox.stories.tsx Added new stories for BaseComboBox component. Included various scenarios like basic usage, typing, default selection, and disabled states. Implemented comprehensive play functions for interaction testing. +326/-0  registerListbox.stories.tsx Introduced stories for BaseListBox with edge case tests.  plasmicpkgs/react-aria/src/registerListbox.stories.tsx Added new stories for BaseListBox component. Covered scenarios like no selection, single selection, and sections. Included tests for edge cases like duplicate and missing IDs. +275/-0  registerSelect.stories.tsx Added BaseSelect stories with interaction tests.                  plasmicpkgs/react-aria/src/registerSelect.stories.tsx Added new stories for BaseSelect component. Included scenarios for basic usage, disabled options, and canvas selection. Enhanced interaction testing with detailed play functions. +272/-0  registerSlider.stories.tsx Introduced BaseSlider stories with range and single slider tests. plasmicpkgs/react-aria/src/registerSlider.stories.tsx Added new stories for BaseSlider component. Included scenarios for single and range sliders with various configurations. Enhanced play functions for interaction testing. +248/-0  registerDialogTrigger.stories.tsx Add Storybook stories for BaseDialogTrigger component.      plasmicpkgs/react-aria/src/registerDialogTrigger.stories.tsx Added new Storybook stories for BaseDialogTrigger with various configurations. Implemented interactive tests for modal and popover behaviors. Included a simulated Plasmic canvas environment for testing. +254/-0  registerTooltip.stories.tsx Add Storybook stories for BaseTooltip component.                  plasmicpkgs/react-aria/src/registerTooltip.stories.tsx Added new Storybook stories for BaseTooltip with various configurations. Included tests for hover, focus, and disabled states. Simulated Plasmic canvas environment for testing. +251/-0  registerModal.stories.tsx Add Storybook stories for BaseModal component.                      plasmicpkgs/react-aria/src/registerModal.stories.tsx Added new Storybook stories for BaseModal with different configurations. Implemented tests for dismissable, non-dismissable, and keyboard-dismiss behaviors. Included imperative control examples. +185/-0  registerCheckboxGroup.stories.tsx Add Storybook stories for BaseCheckboxGroup component.      plasmicpkgs/react-aria/src/registerCheckboxGroup.stories.tsx Added new Storybook stories for BaseCheckboxGroup with various configurations. Included tests for basic, default selection, disabled, and read-only states. Added helper functions for generating checkbox items. +151/-0  registerRadioGroup.stories.tsx Add Storybook stories for BaseRadioGroup component.            plasmicpkgs/react-aria/src/registerRadioGroup.stories.tsx Added new Storybook stories for BaseRadioGroup with various configurations. Included tests for basic, default selection, disabled, and read-only states. Added helper functions for generating radio items. +141/-0  registerButton.stories.tsx Add Storybook stories for BaseButton component.                    plasmicpkgs/react-aria/src/registerButton.stories.tsx Added new Storybook stories for BaseButton with various configurations. Implemented tests for basic, auto-focused, disabled, submit, reset, and link buttons. Included reusable test form wrapper for form-related stories. +156/-0  PlasmicImg.stories.tsx Refactor PlasmicImg stories for improved type safety.        packages/react-web/src/stories/PlasmicImg.stories.tsx Refactored story template for PlasmicImg to improve type safety. Updated default export to use satisfies for type checking. +13/-6    registerPopover.stories.tsx Add standalone story for BasePopover component.                    plasmicpkgs/react-aria/src/registerPopover.stories.tsx Added a standalone story for BasePopover. Included tests for visibility and dismissal behavior. +36/-0    expression-parser.spec.ts Add test for renaming variables in object expressions.      platform/wab/src/wab/shared/eval/expression-parser.spec.ts Added test case for renaming variables in object expressions. Improved test coverage for expression parser. +13/-0    hostless-rich-layout.spec.ts Adjusted CSS background-color assertion in Cypress test.  platform/wab/cypress/e2e/hostless-rich-layout.spec.ts Updated CSS background-color check to use rgb instead of rgba. +1/-1      test-runner.ts Introduced Storybook test runner configuration.                    plasmicpkgs/antd5/.storybook/test-runner.ts Added a test runner configuration for Storybook. +9/-0      test-runner.ts Introduced Storybook test runner configuration.                    packages/react-web/.storybook/test-runner.ts Added a test runner configuration for Storybook. +9/-0
Enhancement	54 files PlasmicButton.tsx Refactored PlasmicButton component with state management. packages/create-plasmic-app/cpa-out/react-codegen-ts/src/components/plasmic/create_plasmic_app/PlasmicButton.tsx Updated imports for better modularity and consistency. Added new state management logic using useDollarState. Refactored component rendering logic for clarity and maintainability. +84/-62  PlasmicHomepage.tsx Enhanced PlasmicHomepage with global variants and refactoring. packages/create-plasmic-app/cpa-out/react-codegen-ts/src/components/plasmic/create_plasmic_app/PlasmicHomepage.tsx Updated imports for better modularity and consistency. Refactored component rendering logic for improved readability. Added support for global variants and state management. +62/-38  merge-components.ts Cleaned up imports and added utility for variant keys.      platform/wab/src/wab/shared/site-diffs/merge-components.ts Removed unused imports for cleaner code. Added toVariantKey utility for variant key handling. +1/-25    PlasmicRandomDynamicPageButton.tsx Refactor and enhance PlasmicRandomDynamicPageButton component. packages/create-plasmic-app/cpa-out/react-codegen-ts/src/components/plasmic/create_plasmic_app/PlasmicRandomDynamicPageButton.tsx Updated imports to include additional utilities and components. Refactored the onClick handler to simplify navigation logic and remove deprecated wrapping functions. Adjusted the handling of args to filter out undefined values. Added submitsForm attribute to the Button component. +83/-70  PlasmicDynamicPage.tsx Refactor and enhance PlasmicDynamicPage component.              packages/create-plasmic-app/cpa-out/react-codegen-ts/src/components/plasmic/create_plasmic_app/PlasmicDynamicPage.tsx Updated imports to include additional utilities and components. Refactored args handling to filter out undefined values. Adjusted rendering logic for dynamic content with enhanced error handling. Replaced deprecated wrapping functions with direct logic. +73/-44  file-utils.ts Refactor generateWelcomePage utility function.                      packages/create-plasmic-app/src/utils/file-utils.ts Refactored generateWelcomePage to improve readability and modularity. Adjusted logic for handling pages and their links. +44/-30  ComponentPropModal.tsx Enhance ComponentPropModal with dropdown menus and color type. platform/wab/src/wab/client/components/modals/ComponentPropModal.tsx Added dropdown menus for managing default and preview values. Introduced a new color type option in the parameter type dropdown. +48/-7    projects.ts Add prefillPkgVersion function and refactor related routes. platform/wab/src/wab/server/routes/projects.ts Added prefillPkgVersion function for pre-filling package versions. Refactored tryMergeBranch and publishProject to use the new function. +52/-31  VariantControls.tsx Refactor variant controls for better management.                  platform/wab/src/wab/client/components/VariantControls.tsx Refactored logic for removing empty or duplicate variants. Improved handling of variant selectors. +44/-25  CmsModelDetails.tsx Add confirmation dialog for model deletion.                            platform/wab/src/wab/client/components/cms/CmsModelDetails.tsx Added confirmation dialog for deleting models. Improved user interaction for model deletion. +22/-15  server.ts Add server query utilities for data handling.                        packages/data-sources/src/serverQueries/server.ts Added utility functions for handling server queries and undefined data. Introduced executeServerQuery for executing server-side queries. +71/-0    canvas-rendering.ts Enhance canvas rendering with UUID-based tracking.              platform/wab/src/wab/client/components/canvas/canvas-rendering.ts Added support for UUID-based repetition index tracking. Introduced computeFullKey for generating unique keys. +14/-0    utils.ts Improve global hook environment handling.                                platform/wab/src/wab/client/react-global-hook/utils.ts Added functions for retrieving environments using full keys. Enhanced environment handling for global hooks. +23/-4    StudioCtx.tsx Enhance zoom-to-fit functionality in StudioCtx.                    platform/wab/src/wab/client/studio-ctx/StudioCtx.tsx Added methods for zooming to fit specific DOM elements or templates. Improved viewport management in the studio context. +36/-16  site-ops.tsx Enhance site operations for variant management.                    platform/wab/src/wab/client/components/canvas/site-ops.tsx Added logic to handle duplicate component variants. Improved variant removal logic for better consistency. +29/-5    model-util.ts Enhance model utilities for color type handling.                  platform/wab/src/wab/shared/model/model-util.ts Updated color type factory to handle optional parameters. Improved type handling for model utilities. +15/-6    CanvasCommentMarkers.tsx Add canvas comment posting functionality.                                platform/wab/src/wab/client/components/comments/CanvasCommentMarkers.tsx Added support for posting comments directly on the canvas. Introduced CanvasCommentPost component for new thread creation. +25/-0    VariantsPanel.tsx Simplify variant panel logic.                                                        platform/wab/src/wab/client/components/variants/VariantsPanel.tsx Removed unused clone functionality for variants. Simplified variant editing logic. +3/-33    private-style-variants-section.tsx Simplify private style variants section logic.                      platform/wab/src/wab/client/components/sidebar-tabs/private-style-variants-section.tsx Removed unused clone functionality for private style variants. Simplified variant editing logic. +3/-24    site-invariants.ts Refactor site invariants for variant key handling.              platform/wab/src/wab/shared/site-invariants.ts Refactored variant key generation logic for better consistency. Improved validation of variant settings. +3/-24    ExtractComponentModal.tsx Optimize ExtractComponentModal rendering.                                platform/wab/src/wab/client/components/modals/ExtractComponentModal.tsx Added unique keys to dynamically generated elements for React optimization. Improved rendering logic for component extraction modal. +7/-3      Button.tsx Refactor Button component type definitions.                            packages/create-plasmic-app/cpa-out/react-codegen-ts/src/components/Button.tsx Adjusted type definitions for ButtonProps. Simplified default export assignment. +4/-5      PlasmicGlobalVariant__Screen.tsx Remove deprecated ScreenVariantProvider and simplify hook. packages/create-plasmic-app/cpa-out/react-codegen-ts/src/components/plasmic/create_plasmic_app/PlasmicGlobalVariant__Screen.tsx Removed deprecated ScreenVariantProvider. Simplified screen variant hook creation. +2/-14    CmsEntryDetails.tsx Add confirmation dialog for CMS entry deletion.                    platform/wab/src/wab/client/components/cms/CmsEntryDetails.tsx Added confirmation dialog for deleting CMS entries. Improved user interaction for entry deletion. +15/-8    data.tsx Optimize DataProvider with memoization.                                    packages/host/src/data.tsx Optimized DataProvider by memoizing child context values. Improved performance for nested data providers. +15/-9    Variants.ts Add utilities for variant key generation and duplication checks. platform/wab/src/wab/shared/Variants.ts Added toVariantKey utility for generating unique variant keys. Introduced logic to find duplicate component variants. +32/-0    CommentPostForm.tsx Enhance CommentPostForm with new thread template support. platform/wab/src/wab/client/components/comments/CommentPostForm.tsx Added support for selecting new thread templates in comment form. Improved comment posting logic. +3/-1      DbMgr.ts Update publishProject to include package version summary. platform/wab/src/wab/server/db/DbMgr.ts Updated publishProject to return package version summary. Improved handling of published project data. +6/-3      globalHook.ts Improve global hook context with full key mapping.              platform/wab/src/wab/client/react-global-hook/globalHook.ts Added mapping for full keys to environment IDs. Enhanced global hook context for environment handling. +3/-0      tpl-menu.tsx Add comment option and improve zoom-to-fit in template menu. platform/wab/src/wab/client/components/tpl-menu.tsx Added menu option to add comments to templates. Improved zoom-to-fit functionality for templates. +15/-2    registerModal.tsx Enhance BaseModal with standalone and controlled state handling. plasmicpkgs/react-aria/src/registerModal.tsx Updated BaseModal to handle standalone and controlled states. Added TODO for addressing defaultOpen behavior in nested modals. +4/-2      registerDialogTrigger.tsx Update BaseDialogTriggerProps for better type integration. plasmicpkgs/react-aria/src/registerDialogTrigger.tsx Updated BaseDialogTriggerProps to exclude children from DialogTriggerProps. Improved type definitions for better integration. +4/-2      view-ctx.ts Add new thread template selection in view context.              platform/wab/src/wab/client/studio-ctx/view-ctx.ts Added support for selecting new thread templates in view context. Improved state management for thread selection. +11/-0    registerSelect.tsx Enhance BaseSelectProps with Plasmic canvas info.                plasmicpkgs/react-aria/src/registerSelect.tsx Added WithPlasmicCanvasComponentInfo to BaseSelectProps. Improved type integration for Plasmic canvas components. +2/-0      index.ts Add JSX runtime support to global Sub object.                        packages/host/src/index.ts Added jsxRuntime and jsxDevRuntime to the global Sub object. Improved runtime compatibility for JSX. +4/-0      parser-utils.ts Enhance writeJs utility with optional semicolon support.  platform/wab/src/wab/shared/parser-utils.ts Added support for optional semicolons in JavaScript code generation. Improved flexibility of writeJs utility. +5/-1      ApiSchema.ts Add PkgVersionSummary type and update merge results.          platform/wab/src/wab/shared/ApiSchema.ts Added PkgVersionSummary type for summarizing package versions. Updated merge result interfaces to include package version summaries. +9/-0      registerComboBox.tsx Enhance BaseComboboxProps with Plasmic canvas info.            plasmicpkgs/react-aria/src/registerComboBox.tsx Added WithPlasmicCanvasComponentInfo to BaseComboboxProps. Improved type integration for Plasmic canvas components. +2/-0      registerPopover.tsx Enhance BasePopoverProps with Plasmic canvas info.              plasmicpkgs/react-aria/src/registerPopover.tsx Added WithPlasmicCanvasComponentInfo to BasePopoverProps. Improved type integration for Plasmic canvas components. +2/-0      registerTooltip.tsx Enhance BaseTooltipProps with Plasmic canvas info.              plasmicpkgs/react-aria/src/registerTooltip.tsx Added WithPlasmicCanvasComponentInfo to BaseTooltipProps. Improved type integration for Plasmic canvas components. +2/-0      index.ts Add UUID-based repetition index utility.                                  platform/wab/src/wab/shared/codegen/react-p/data-reps/index.ts Added utility for generating UUID-based repetition index names. Improved data representation utilities for React codegen. +4/-0      model-schema.ts Add ColorPropType to model schema.                                              platform/wab/src/wab/shared/model/model-schema.ts Added ColorPropType to the list of supported property types. Updated schema to reflect new color property type. +1/-1      main.tsx Add main entry point for React Vite app.                                  packages/create-plasmic-app/cpa-out/react-codegen-ts/src/main.tsx Added main entry point for React Vite application. Included strict mode and root rendering logic. +10/-0    code-components.ts Improved type handling for color properties.                          platform/wab/src/wab/shared/code-components/code-components.ts Removed temporary type casting for color type handling. +1/-4      utils.ts Introduced new type for Plasmic canvas component info.      plasmicpkgs/react-aria/src/utils.ts Added a new type WithPlasmicCanvasComponentInfo. +7/-0      types.ts Extended GlobalHookCtx with new mapping.                                  platform/wab/src/wab/client/react-global-hook/types.ts Added a new map fullKeyToEnvId to GlobalHookCtx interface. +1/-0      index.tsx Added server query utilities to data sources.                        packages/data-sources/src/index.tsx Exported new server query functions and types. +6/-0      expression-parser.ts Adjusted JavaScript code generation to omit semicolons.    platform/wab/src/wab/shared/eval/expression-parser.ts Modified writeJs function call to disable semicolons. +1/-1      types.ts Introduced types for server query handling.                            packages/data-sources/src/types.ts Added new interfaces ServerQuery and ServerQueryResult. +10/-0    registerSliderTrack.tsx Enhanced type definition for slider track children.            plasmicpkgs/react-aria/src/registerSliderTrack.tsx Updated children prop type to React.ReactNode. +1/-1      PropValueEditor.tsx Extended PropValueEditor with value state management.        platform/wab/src/wab/client/components/sidebar-tabs/PropValueEditor.tsx Added valueSetState prop to PropValueEditor_. +1/-0      registerButton.tsx Made BaseButtonProps interface exportable.                              plasmicpkgs/react-aria/src/registerButton.tsx Exported BaseButtonProps interface. +1/-1      main.sass Enhanced styles for comment markers.                                          platform/wab/src/wab/styles/main.sass Added styles for .CommentPostMarker and .CommentPostFormMarker. +4/-1      PlasmicButton.jsx Refactored and optimized PlasmicButton component.                packages/create-plasmic-app/cpa-out/react-codegen-js/src/components/plasmic/create_plasmic_app/PlasmicButton.jsx Refactored imports and removed unused variables. Updated state initialization logic. Simplified slot rendering logic. +47/-96
Configuration changes	15 files react.ts Migrate project creation to Vite and update TypeScript config. packages/create-plasmic-app/src/react/react.ts Switched from Create React App to Vite for project creation. Added logic to handle directory creation and navigation for Vite. Updated TypeScript configuration to disable noUnusedLocals. +47/-16  index.ts Update CLI for Vite-based project creation.                            packages/create-plasmic-app/src/index.ts Updated CLI to reflect the switch from Create React App to Vite. Adjusted prompts and validation logic accordingly. +10/-12  main.ts Migrate Storybook config to TypeScript and add SWC.            plasmicpkgs/antd5/.storybook/main.ts Migrated Storybook configuration to TypeScript. Added SWC compiler addon for improved performance. +6/-4      main.ts Migrate Storybook config to TypeScript and add SWC.            packages/react-web/.storybook/main.ts Migrated Storybook configuration to TypeScript. Added SWC compiler addon for improved performance. +6/-4      main.ts Add Storybook configuration for React Aria package.            plasmicpkgs/react-aria/.storybook/main.ts Added new Storybook configuration for React Aria package. Included SWC compiler addon for improved performance. +16/-0    lib.ts Changed React platform default command to `dev`.                  packages/create-plasmic-app/src/lib.ts Updated default npmRunCmd for React platform to use dev. +1/-1      devflags.ts Updated development flags configuration.                                  platform/wab/src/wab/shared/devflags.ts Disabled componentThumbnails dev flag. +1/-1      preview.ts Configured Storybook preview parameters.                                  plasmicpkgs/antd5/.storybook/preview.ts Added Storybook parameters for actions and controls. [link]    preview.ts Configured Storybook preview parameters.                                  packages/react-web/.storybook/preview.ts Added Storybook parameters for actions and controls. [link]    vite.config.ts Added Vite configuration for React TypeScript.                      packages/create-plasmic-app/cpa-out/react-codegen-ts/vite.config.ts Added Vite configuration file for React codegen TypeScript project. +7/-0      preview.ts Introduced basic Storybook preview configuration.                plasmicpkgs/react-aria/.storybook/preview.ts Added a minimal Storybook preview configuration. +4/-0      vite-env.d.ts Included Vite environment type definitions.                            packages/create-plasmic-app/cpa-out/react-codegen-ts/src/vite-env.d.ts Added Vite environment type reference. +1/-0      eslint.config.js Introduced ESLint configuration for React JavaScript.        packages/create-plasmic-app/cpa-out/react-codegen-js/eslint.config.js Added ESLint configuration for JavaScript codegen project. +38/-0    eslint.config.js Introduced ESLint configuration for React TypeScript.        packages/create-plasmic-app/cpa-out/react-codegen-ts/eslint.config.js Added ESLint configuration for TypeScript codegen project. +28/-0    vite.config.js Added Vite configuration for React JavaScript.                      packages/create-plasmic-app/cpa-out/react-codegen-js/vite.config.js Added Vite configuration file for React codegen JavaScript project. +7/-0
Bug fix	4 files ColorButton.tsx Fix color button behavior and improve accessibility.          platform/wab/src/wab/client/components/style-controls/ColorButton.tsx Fixed issue with empty color values defaulting to white. Added type attribute to button for better accessibility. +3/-2      ColorPicker.tsx Fix empty color handling in ColorPicker.                                  platform/wab/src/wab/client/components/widgets/ColorPicker/ColorPicker.tsx Fixed issue with empty color values defaulting to white. Improved color picker initialization logic. +4/-1      components.ts Fixed template slot filtering logic.                                          platform/wab/src/wab/shared/core/components.ts Replaced oldTpls with newTpls in filtering template slots. +1/-1      helpers.ts Improved key handling in object manipulation helper.          packages/react-web/src/states/helpers.ts Ensured keys are converted to strings in the set function. +1/-1
Formatting	2 files PlasmicIcon__Checksvg.tsx Rename ChecksvgIcon for consistent naming.                              packages/create-plasmic-app/cpa-out/react-codegen-ts/src/components/plasmic/create_plasmic_app/icons/PlasmicIcon__Checksvg.tsx Renamed ChecksvgIcon to CheckSvgIcon for consistent naming. Updated type definitions and default export accordingly. +3/-3      App.tsx Minor formatting changes in App.tsx.                                          packages/create-plasmic-app/cpa-out/react-codegen-ts/src/App.tsx Removed trailing whitespace and added a newline at the end of the file. +1/-1
Additional files	101 files package.json +16/-2    .eslintrc.js +0/-15    package.json +22/-32  plasmic.json +16/-10  App.jsx +1/-1      Button.jsx +1/-3      PlasmicDynamicPage.jsx +35/-29  PlasmicGlobalVariant__Screen.jsx +2/-14    PlasmicHomepage.jsx +24/-24  PlasmicRandomDynamicPageButton.jsx +44/-58  PlasmicIcon__Checksvg.jsx +2/-2      index.js +0/-17    main.jsx +10/-0    reportWebVitals.js +0/-13    setupTests.js +0/-5      package.json +23/-37  plasmic.json +16/-10  index.tsx +0/-19    react-app-env.d.ts +0/-1      reportWebVitals.ts +0/-15    setupTests.ts +0/-5      tsconfig.json +4/-23    package.json +0/-40    plasmic.json +0/-127  App.jsx +0/-9      Button.jsx +0/-13    DynamicPage.jsx +0/-26    Homepage.jsx +0/-26    RandomDynamicPageButton.jsx +0/-24    PlasmicButton.jsx +0/-625  PlasmicDynamicPage.jsx +0/-166  PlasmicGlobalVariant__Screen.jsx +0/-29    PlasmicHomepage.jsx +0/-210  PlasmicRandomDynamicPageButton.jsx +0/-161  PlasmicIcon__Checksvg.jsx +0/-39    PlasmicIcon__Icon.jsx +0/-37    index.js +0/-17    reportWebVitals.js +0/-13    setupTests.js +0/-5      package.json +0/-45    plasmic.json +0/-127  App.tsx +0/-9      Button.tsx +0/-36    DynamicPage.tsx +0/-45    Homepage.tsx +0/-45    RandomDynamicPageButton.tsx +0/-44    PlasmicButton.tsx +0/-725  PlasmicDynamicPage.tsx +0/-248  PlasmicGlobalVariant__Screen.tsx +0/-31    PlasmicHomepage.tsx +0/-294  PlasmicRandomDynamicPageButton.tsx +0/-240  PlasmicIcon__Checksvg.tsx +0/-44    PlasmicIcon__Icon.tsx +0/-41    index.tsx +0/-19    react-app-env.d.ts +0/-1      reportWebVitals.ts +0/-15    setupTests.ts +0/-5      tsconfig.json +0/-26    package.json +4/-12    index.api.md +25/-0    package.json +2/-2      package.json +1/-1      package.json +2/-2      package.json +2/-2      package.json +2/-2      package.json +2/-2      package.json +2/-2      package.json +2/-2      package.json +5/-17    package.json +2/-2      package.json +2/-2      package.json +10/-23  package.json +2/-2      package.json +2/-2      package.json +3/-3      package.json +3/-3      package.json +3/-3      package.json +3/-3      package.json +3/-3      package.json +2/-2      package.json +2/-2      package.json +2/-2      package.json +2/-2      package.json +2/-2      package.json +2/-2      package.json +2/-2      package.json +2/-2      package.json +2/-2      package.json +2/-2      package.json +2/-2      package.json +2/-2      package.json +2/-2      package.json +2/-2      package.json +2/-2      package.json +2/-2      package.json +2/-2      package.json +3/-3      package.json +2/-2      package.json +2/-2      package.json +2/-2      Additional files not shown

---

Need help?

Type /help how to ... in the comments thread for any questions about Qodo Merge usage.

Check out the documentation for more information.

[qodo-code-review]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 3 🔵🔵🔵⚪⚪

🧪 PR contains tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Code Cleanup Multiple instances of redundant type casting and error handling code were removed and simplified. Validate that the functionality remains intact after these cleanups. RepeatedStates.play = async ({ canvasElement }) => { const canvas = within(canvasElement); const expectedCount = [1, 2, 4]; for (let i = 0; i < expectedCount.length; i++) { await click(canvas.getByTestId(`counter[${i}]-btn`), expectedCount[i]); } for (let i = 0; i < expectedCount.length; i++) { await expect(canvas.getByTestId(`counter[${i}]-label`).textContent).toEqual( `Counter: ${expectedCount[i]}` ); } const subsets = getAllSubsets([0, 1, 2]) .sort((a, b) => a.length - b.length) .filter((set) => set.length); for (let i = 0; i < subsets.length; i++) { await expect(canvas.getByTestId(`test${i}-label`).textContent).toEqual( `Counter: ${subsets[i].reduce((acc, el) => acc + expectedCount[el], 0)}` ); } }; Broken Tests Multiple form-related tests are marked as "skip-test" with a comment indicating "simplified forms broken". This needs investigation to understand and fix the underlying issues. export const SimplifiedForm = _SimplifiedForm.bind({}); SimplifiedForm.tags = ["skip-test"]; // simplified forms broken? SimplifiedForm.args = {

[qodo-code-review]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Impact
Possible issue	Add navigation error handling Add error handling for navigation failures in the onClick handler. The current implementation assumes navigation will always succeed but could fail due to invalid URLs or network issues. packages/create-plasmic-app/cpa-out/react-codegen-ts/src/components/plasmic/create_plasmic_app/PlasmicRandomDynamicPageButton.tsx [91-125] onClick={async event => { const $steps = {}; $steps["goToDynamicPage"] = true ? (() => { const actionArgs = { destination: `/dynamic/${(() => { try { return Math.random().toString(36).slice(2); } catch (e) { if ( e instanceof TypeError || e?.plasmicType === "PlasmicUndefinedDataError" ) { return "value"; } throw e; } })()}` }; return (({ destination }) => { - if ( - typeof destination === "string" && - destination.startsWith("#") - ) { - document - .getElementById(destination.substr(1)) - .scrollIntoView({ behavior: "smooth" }); - } else { - location.assign(destination); + try { + if ( + typeof destination === "string" && + destination.startsWith("#") + ) { + document + .getElementById(destination.substr(1)) + ?.scrollIntoView({ behavior: "smooth" }); + } else { + location.assign(destination); + } + } catch (err) { + console.error("Navigation failed:", err); } })?.apply(null, [actionArgs]); })() : undefined; }} [To ensure code accuracy, apply this suggestion manually] Suggestion importance[1-10]: 8 __ Why: The suggestion adds important error handling for navigation failures that could occur due to invalid URLs or missing DOM elements, preventing uncaught exceptions from crashing the application.	Medium
	Fix text input handling The justType function implementation is incomplete - it clears the field but doesn't handle empty text case properly. This could cause issues with form validation. plasmicpkgs/antd5/src/stories/Form.stories.tsx [1399-1404] const justType = async (element: HTMLElement, text: string) => { await userEvent.clear(element); - if (text) { + if (text !== undefined) { await userEvent.type(element, text); } }; [To ensure code accuracy, apply this suggestion manually] Suggestion importance[1-10]: 3 __ Why: The suggestion makes a minor improvement to input handling by checking for undefined instead of falsy values, but the practical impact is minimal since empty strings would be handled the same way in both cases.	Low
General	Document test skip reasoning The skip-test tags are added with unclear reasoning. The comment "simplified forms broken?" suggests potential issues that should be investigated and fixed rather than skipped. plasmicpkgs/antd5/src/stories/Form.stories.tsx [157] -SimplifiedForm.tags = ["skip-test"]; // simplified forms broken? +// TODO: Investigate and fix simplified form issues before re-enabling tests +SimplifiedForm.tags = ["skip-test"]; [To ensure code accuracy, apply this suggestion manually] Suggestion importance[1-10]: 2 __ Why: While the suggestion improves code documentation by adding a TODO comment, it doesn't address the underlying issue and only suggests documenting why tests are being skipped.	Low