-
-
Notifications
You must be signed in to change notification settings - Fork 0
Auto merge package updates from renovate #354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,68 @@ | ||
| # Copilot Instructions | ||
|
|
||
| ## Philosophy | ||
|
|
||
| - **Pure Functions**: Favor pure functions (no side effects, no mutation, deterministic) as advocated by Eric Elliott. | ||
| - **Test-Driven Development (TDD)**: Write tests first, code in small, testable increments, following Uncle Bob’s TDD cycle. | ||
| - **Extreme Programming (XP)**: Embrace simplicity, communication, feedback, and courage. Prefer small, frequent, high-quality changes. | ||
| - **Framework Agnostic**: Do not use any frameworks or libraries unless explicitly requested. Use only standard JavaScript (ESM). | ||
| - **JSDoc**: All functions, classes, and modules must be documented with JSDoc for type safety and clarity. | ||
| - **Design Patterns**: Use classic, well-known patterns (factory, strategy, observer, etc.) only when they add clarity or testability. | ||
| - **Clean Code**: Prioritize readability, maintainability, and simplicity. Avoid cleverness for its own sake. | ||
| - **Testability**: All code should be easily testable. Avoid hidden dependencies and global state. | ||
| - **Small Iterations**: Make small, incremental changes. Each change should be easy to review and test. | ||
| - **No Frameworks**: Do not use React, Vue, Angular, or any other framework. No build tools unless explicitly requested. | ||
|
|
||
| ## Coding Guidelines | ||
|
|
||
| - Use **ES Modules** (`import`/`export`). | ||
| - Use **pure functions** wherever possible. | ||
| - Use **const** and **let** (never `var`). | ||
| - Use **arrow functions** for short, stateless functions. | ||
| - Use **descriptive names** for variables, functions, and classes. | ||
| - **No mutation** of input arguments. | ||
| - **No side effects** in pure functions. | ||
| - **No global state** unless absolutely necessary (and then, document it). | ||
| - **JSDoc** for every function, class, and exported symbol. | ||
| - **Write a test** for every new function or feature (see `/src/*.test.js` for examples). | ||
| - **Keep files small** and focused on a single responsibility. | ||
| - **No magic numbers**—use named constants. | ||
| - **No unnecessary abstractions**—keep it simple. | ||
|
|
||
| ## Example Function | ||
|
|
||
| ```js | ||
| /** | ||
| * Adds two numbers (pure function). | ||
| * @param {number} a | ||
| * @param {number} b | ||
| * @returns {number} | ||
| */ | ||
| export const add = (a, b) => a + b | ||
| ``` | ||
|
|
||
| ## Example Test | ||
|
|
||
| ```js | ||
| import assert from 'node:assert/strict' | ||
| import { add } from './add.js' | ||
|
|
||
| assert.equal(add(2, 3), 5) | ||
| ``` | ||
|
|
||
| ## When in Doubt | ||
|
|
||
| - **Ask for clarification** if requirements are unclear. | ||
| - **Prefer simplicity** over cleverness. | ||
| - **Write tests** for all edge cases. | ||
| - **Document** all exported symbols with JSDoc. | ||
|
|
||
| --- | ||
|
|
||
| **Summary:** | ||
| Write clean, pure, framework-agnostic JavaScript (ESM) with JSDoc and tests. | ||
| Favor small, testable, incremental changes. | ||
| No frameworks, no unnecessary abstractions, no side effects. | ||
|
|
||
| --- | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1 +1 @@ | ||||||
| 22.16.0 | ||||||
| 24 | ||||||
|
||||||
| 24 | |
| 24.0.0 |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Caching the entire node_modules directory can lead to large cache sizes and slower actions; consider only caching the npm cache directory (~/.npm) and reinstalling dependencies for a smaller cache footprint.