Fix crash when termcap is used and cursor_left is unavailable#77
Merged
troglobit merged 1 commit intotroglobit:masterfrom Feb 16, 2026
Merged
Fix crash when termcap is used and cursor_left is unavailable#77troglobit merged 1 commit intotroglobit:masterfrom
troglobit merged 1 commit intotroglobit:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If termcap is used and the
cursor_leftterminal capability is not available, editline will segfault on most actions: for instance, deleting a character.Summary of the changes:
tgetentreturns -1 if the terminfo database cannot be loaded, 0 if the terminal name could not be found in the database and 1 on success. I updated the return value check.tgetstr("le", &bp)returnsNULL(thecursor_leftcapability is not available), it is preferable to keepbackspaceto its default value rather than assigning it toNULL. This is what causes the segfault.