Start trying to get keyconfig back to work#32
Open
oeekker wants to merge 1 commit intotrlkly:masterfrom
Open
Conversation
|
it would be a lot better nicer diff if you didn't change line end encoding. aside from that, how to test this branch? i.e how build and make my tb to use this branch build? |
Author
|
On 1/8/2020 10:29 AM, Elan Ruusamäe wrote:
it would be a lot better nicer diff if you didn't change line end
encoding.
also you should never submit pull request from master branch, as any
commits to your master branch appear into merge request, that may not
be the intention typically.
aside from that, how to test this branch? i.e how build and make my tb
to use this branch build?
Hi, sorry if I didn't do the pull request in the right way, I'm not used
that much in collaborating. Anyway,it's too long ago that I looked into
this, so I don't remember how it worked exactly and I kind of lost
interest since the whole overlay loader will be dropped in Thunderbird
78 anyway making all changes we do now for Thunderbird 68 moot for the
next version :-(
Onno
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebinding already configure keys starts working for me again ib TB68,
Still need to make restore configuring though...