add sample order checks and updated find_column_names function#38
Open
add sample order checks and updated find_column_names function#38
Conversation
|
|
||
| ```{r} | ||
| # Check for differences between the two lists | ||
| setdiff(names(OTU_table), data_samples$SampleID) # This tells us which samples are present in first set that aren't present in second set - if you get output here, we need to clean up names |
Contributor
There was a problem hiding this comment.
What does "set" mean here in this description? Can it be more specific (e.g. samples present in OTU table versus samples present in metadata)?
|
|
||
| ```{r} | ||
| # Check for differences between the two lists | ||
| setdiff(names(OTU_table), data_samples$SampleID) # This tells us which samples are present in first set that aren't present in second set - if you get output here, we need to clean up names |
Contributor
There was a problem hiding this comment.
Same comment as above regarding the use of the word "set" in description.
Contributor
|
Other than my comment regarding the word "set" in the code description, the rest looks great and I think it can be merged :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added code in 4a and 4b to check that SampleID order is the same between metadata and OTU table data frames before combining into a phyloseq object, and changed soon-to-be deprecated function to more current 'extract_column_names()' function.
Closes #37